Open martinzi opened 1 month ago
Attention: Patch coverage is 7.61180%
with 971 lines
in your changes missing coverage. Please review.
Project coverage is 42.93%. Comparing base (
2b41187
) to head (3c37296
). Report is 856 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@martinzi Thanks for splitting this out!
A few suggestions:
script/make-pretty
to format your code.BRs!
Please be aware that there is also another PR adding the commissioner feature to REST API https://github.com/openthread/ot-br-posix/pull/2515
…by indirect 'addThreadDeviceTask' processing
This PR is a carve-out from PR2514 to ease review. It implements the 'addThreadDeviceTask' to add a Joiner and auto-start on-mesh commissioner after POST:
addThreadDeviceTask
on api/actions/The commit also provides limited integration tests, see tests/restjsonapi.
Please follow below steps to reproduce and install/build OTBR.
Checkout this PR
Build and Install OTBR as usual, e.g. on a Raspberry Pi
Restart the OTBR.
sudo systemctl restart otbr-agent
To monitor the log [Errors|Warnings|Info] please open a different terminal instance and use following command:
should return
should return
sudo ot-ctl commissioner joiner table
and expectStart your joiner and after a few seconds repeat above steps 6. and 7.
For running the included test script install Bruno-Cli and run the bash script on your border router