search

openthread / ot-commissioner

OpenThread Commissioner, a Thread commissioner for joining new Thread devices and managing Thread networks.
https://openthread.io/
BSD 3-Clause "New" or "Revised" License
49 stars 36 forks source link

[joiner] validate joiner PSKd #101

Closed wgtdkp closed 4 years ago

wgtdkp commented 4 years ago

This PR addes validation of joiner PSKd to force it conform to the Thread Spec. It also changes PSKd from ByteArray to std::string since PSKd can be only digits and uppercase chars.

related comments: https://github.com/openthread/ot-commissioner/pull/72#discussion_r409654671

codecov-io commented 4 years ago

Codecov Report

Merging #101 into master will increase coverage by 0.06%. The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   61.08%   61.14%   +0.06%     
==========================================
  Files          55       55              
  Lines        5381     5392      +11     
==========================================
+ Hits         3287     3297      +10     
- Misses       2094     2095       +1
Impacted Files Coverage Δ
include/commissioner/commissioner.hpp 100.00% <ø> (ø)
src/app/commissioner_app.hpp 75.00% <ø> (ø)
src/app/cli/interpreter.cpp 37.88% <50.00%> (ø)
src/app/commissioner_app.cpp 29.04% <83.33%> (+1.03%) :arrow_up:
src/library/commissioner_impl.cpp 61.90% <100.00%> (ø)
src/library/joiner_session.cpp 85.96% <100.00%> (ø)