search

openthread / ot-commissioner

OpenThread Commissioner, a Thread commissioner for joining new Thread devices and managing Thread networks.
https://openthread.io/
BSD 3-Clause "New" or "Revised" License
49 stars 36 forks source link

[continuous-integration] remove Travis CI #104

Closed wgtdkp closed 4 years ago

wgtdkp commented 4 years ago

This PR removes Travis CI since we have GitHub Action now.

codecov-io commented 4 years ago

Codecov Report

Merging #104 into master will decrease coverage by 1.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   61.37%   60.33%   -1.05%     
==========================================
  Files          55       55              
  Lines        5367     5259     -108     
==========================================
- Hits         3294     3173     -121     
- Misses       2073     2086      +13
Impacted Files Coverage Δ
src/library/coap.hpp 9.09% <0.00%> (-80.20%) :arrow_down:
src/library/timer.hpp 18.51% <0.00%> (-77.92%) :arrow_down:
src/library/endpoint.hpp 33.33% <0.00%> (-66.67%) :arrow_down:
src/app/cli/main.cpp 66.66% <0.00%> (-22.23%) :arrow_down:
src/library/cbor.hpp 80.00% <0.00%> (-20.00%) :arrow_down:
src/library/udp_proxy.hpp 80.00% <0.00%> (-13.34%) :arrow_down:
src/library/openthread/crc16.hpp 100.00% <0.00%> (ø)
include/commissioner/commissioner.hpp 33.33% <0.00%> (+2.56%) :arrow_up:
src/library/coap_secure.hpp 80.00% <0.00%> (+10.43%) :arrow_up:
src/common/utils.hpp 100.00% <0.00%> (+34.78%) :arrow_up:
wgtdkp commented 4 years ago

There is significant decrease of code coverage, investigating.

wgtdkp commented 4 years ago

There is significant decrease of code coverage, investigating.

It seems the codecov bash script is counting coverage incorrectly. we can take this timer.hpp report for example, the destructor is executed while the constructor is never executed. This is not possible.

The new commit https://github.com/openthread/ot-commissioner/pull/104/commits/26eeeac374729d852e9819f9b27a95bae53f962f switch to generate coverage summary at local and feed it to the codecov bash script. The timer.hpp report now looks fine.

Not sure why the codecov bash script works well on travis but not on GitHub Action.