search

openthread / ot-commissioner

OpenThread Commissioner, a Thread commissioner for joining new Thread devices and managing Thread networks.
https://openthread.io/
BSD 3-Clause "New" or "Revised" License
52 stars 35 forks source link

[cmake] lower minimum cmake version #139

Closed wgtdkp closed 4 years ago

wgtdkp commented 4 years ago

This PR

  1. changes the minimum required CMake version from 3.13.1 to 3.10.1 since many platforms (ubuntu, android studio) have 3.10.X as the default CMake version
  2. submodule mdns is updated to support this change
  3. avoid inclusion of unnecessary third parties
codecov-commenter commented 4 years ago

Codecov Report

Merging #139 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   64.96%   64.96%           
=======================================
  Files          52       52           
  Lines        4755     4755           
=======================================
  Hits         3089     3089           
  Misses       1666     1666
wgtdkp commented 4 years ago

reopen PR to trigger re-run of GitHub Action.

wgtdkp commented 4 years ago

Seems we need to make changes (refactor unittests build) to current CMake files to work with 3.10.1 version. Mark this PR as work-in-progress.

wgtdkp commented 4 years ago

Looks good overall. Please help resolve conflicts.

@jwhui done!