search

openthread / ot-commissioner

OpenThread Commissioner, a Thread commissioner for joining new Thread devices and managing Thread networks.
https://openthread.io/
BSD 3-Clause "New" or "Revised" License
52 stars 35 forks source link

[dataset] fix and relax dataset response check #186

Closed wgtdkp closed 3 years ago

wgtdkp commented 3 years ago
  1. The Pending Dataset check is wrong: the bitwise or (|) should be bitwise and (&)
  2. Both Pending and Active Dataset Get response checks are too restrict.

The Commissioner CLI always sends MGMT_ACTIVE/PENDING_GET.req for all TLVs even when only a single TLV is requested by the user and thus current implementation is working.

wgtdkp commented 3 years ago

By the way, this is not related to the IOP issue with the Kirale BR.