search

openthread / ot-commissioner

OpenThread Commissioner, a Thread commissioner for joining new Thread devices and managing Thread networks.
https://openthread.io/
BSD 3-Clause "New" or "Revised" License
49 stars 36 forks source link

[joiner-session] invoke "OnJoinerRequest" for the first joiner message #196

Closed wgtdkp closed 3 years ago

wgtdkp commented 3 years ago

Current implementation invokes OnJoinerRequest for every joiner message exchanges. This will result in the user be notified multiple times for the same joiner connection.

This commits changes to invoke OnJoinerRequest for the first message of a joiner connection.

codecov-commenter commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@1b5dd47). Click here to learn what that means. The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage        ?   69.40%           
=======================================
  Files           ?       52           
  Lines           ?     4874           
  Branches        ?        0           
=======================================
  Hits            ?     3383           
  Misses          ?     1491           
  Partials        ?        0
Impacted Files Coverage Δ
src/library/commissioner_impl.cpp 77.00% <50.00%> (ø)