search

openthread / ot-commissioner

OpenThread Commissioner, a Thread commissioner for joining new Thread devices and managing Thread networks.
https://openthread.io/
BSD 3-Clause "New" or "Revised" License
49 stars 36 forks source link

[mdns] accept only A records for IPv4 sockets #198

Closed wgtdkp closed 3 years ago

wgtdkp commented 3 years ago

Since we are discovering MeshCoP (_meshcop._udp) services in IPv4 address space, we should always prefer the A record.

https://github.com/openthread/ot-commissioner/blob/cea03001ddb3493647a183c7796d560b5a6c0fc5/src/app/border_agent.cpp#L73-L74

This PR rejects AAAA records received in a IPv4 socket.

Addresses https://github.com/openthread/ot-br-posix/issues/809.

codecov-commenter commented 3 years ago

Codecov Report

Merging #198 (d340170) into main (cea0300) will decrease coverage by 0.69%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   69.46%   68.76%   -0.70%     
==========================================
  Files          52       52              
  Lines        4876     4867       -9     
==========================================
- Hits         3387     3347      -40     
- Misses       1489     1520      +31
Impacted Files Coverage Δ
src/app/border_agent.cpp 81.95% <50.00%> (+4.49%) :arrow_up:
src/app/cli/interpreter.cpp 52.51% <0.00%> (-7.02%) :arrow_down: