Closed doublemis1 closed 2 years ago
This pull request introduces 1 alert when merging b7be9722e8fa39c73008a485f35b1beea82468b2 into 5f39c84745fc48fd87a7ddf542eb43d8af1d936a - view on LGTM.com
new alerts:
Merging #219 (e66e30c) into main (5f39c84) will not change coverage. The diff coverage is
n/a
.:exclamation: Current head e66e30c differs from pull request most recent head 8487338. Consider uploading reports for the commit 8487338 to get more accurate results
@@ Coverage Diff @@ ## main #219 +/- ## ======================================= Coverage 73.88% 73.88% ======================================= Files 76 76 Lines 7570 7570 ======================================= Hits 5593 5593 Misses 1977 1977
@doublemis1 Please format the code with ./script/make-pretty python
.
@jwhui can this be merged? It's useful for the Thread 1.2 Certification program.
@simonlingoogle so this change should be merged to the cert branch instead of the main?
@simonlingoogle so this change should be merged to the cert branch instead of the main?
I think we can abolish the cert
branch and only use main
branch for ot-commissioner.
We were using cert
branch because the main
branch was less stable back then. Essentially, cert
branch tracks a history commit of the main
branch. However, we can use the ot-commissioner
submodule of the ot-reference-release
project for the same purpose.
So, I suggest that we can merge the change to the main branch only and then update submodule in ot-reference-release
accordingly.
Thoughts? @wgtdkp @superwhd
@simonlingoogle so this change should be merged to the cert branch instead of the main?
I think we can abolish the
cert
branch and only usemain
branch for ot-commissioner.We were using
cert
branch because themain
branch was less stable back then. Essentially,cert
branch tracks a history commit of themain
branch. However, we can use theot-commissioner
submodule of theot-reference-release
project for the same purpose.So, I suggest that we can merge the change to the main branch only and then update submodule in
ot-reference-release
accordingly.Thoughts? @wgtdkp @superwhd
SGTM.
Thread Harness expects the MLR log in PlatfromDiagnosticsPacket class