Closed abtink closed 2 years ago
abtink
commented
2 years ago The CI tests are failing with this change. I re-ran it a bunch of times but it keeps failing. https://github.com/openthread/ot-commissioner/runs/7081574749?check_suite_focus=true
codecov-commenter
commented
2 years ago Merging #229 (66dd2b3) into main (b52e58d) will decrease coverage by
0.00%. The diff coverage isn/a.:exclamation: Current head 66dd2b3 differs from pull request most recent head f911efd. Consider uploading reports for the commit f911efd to get more accurate results
@@ Coverage Diff @@
## main #229 +/- ##
==========================================
- Coverage 74.02% 74.02% -0.01%
==========================================
Files 76 76
Lines 7553 7552 -1
==========================================
- Hits 5591 5590 -1
Misses 1962 1962 | Impacted Files | Coverage Δ | |
|---|---|---|
| include/commissioner/error.hpp | 100.00% <0.00%> (ø) |
wgtdkp
commented
2 years ago The CI tests are failing with this change. I re-ran it a bunch of times but it keeps failing. https://github.com/openthread/ot-commissioner/runs/7081574749?check_suite_focus=true
Sorry I missed the message here, looks like you already figured out the fix!
abtink
commented
2 years ago Sorry I missed the message here, looks like you already figured out the fix!
No worries. Thanks. Yes. We needed to increase the sleep delay after calling the start_leader as well 😄
This commit increases the wait time for leader start. This is to address the changes in behavior in Thread spec related to the number of MLE Parent Request messages that device needs to send in the first attach attempt before it can become leader. The new design requires a device to send a total of six Parent Request messages, first two to routers followed by four to routers and REEDs, each having its own corresponding wait time.