Closed ZhangLe2016 closed 4 months ago
@jwhui seems that I cannot add reviewers into this PR, could you please add me into this project as a contributor? thanks.
Better add this to third_party/libevent/CMakeLists.txt:
set(EVENT__HAVE_PIPE2 0 CACHE BOOL "disable use of pipe2 in libevent" FORCE)
Attention: Patch coverage is 75.00000%
with 7 lines
in your changes are missing coverage. Please review.
Project coverage is 73.35%. Comparing base (
de8e82c
) to head (2704165
). Report is 1 commits behind head on main.:exclamation: Current head 2704165 differs from pull request most recent head 9cc2a53. Consider uploading reports for the commit 9cc2a53 to get more accurate results
When developers run the 'build-commissioner-libs.sh' script multiple times, they might see the following error during compiling the libevent:
error: call to undeclared function 'pipe2'; ISO C99 and later do not support implicit function declarations ...
In fact, we did not use pip2 in libevent. We can turn it off by using the macro EVENT_HAVE-PIPE2=0