[DO NOT REVIEW][epskc] demo version impl for epskc

openthread / ot-commissioner

OpenThread Commissioner, a Thread commissioner for joining new Thread devices and managing Thread networks.

https://openthread.io/

BSD 3-Clause "New" or "Revised" License

49 stars 36 forks source link

[DO NOT REVIEW][epskc] demo version impl for epskc #261

Open wgtdkp opened 4 months ago

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #261 +/- ## ========================================== + Coverage 72.88% 72.92% +0.04% ========================================== Files 72 72 Lines 7500 7482 -18 ========================================== - Hits 5466 5456 -10 + Misses 2034 2026 -8 ``` [see 4 files with indirect coverage changes](https://app.codecov.io/gh/openthread/ot-commissioner/pull/261/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openthread)

wgtdkp commented 4 months ago

Here is an the Android APK prebuilt with the ePSKc support: epskc-commissioner-app-debug.apk.zip. Instead of building from source code, you can download the install the APK to reproduce the latest ePSKc demo.

@jwhui In case this can ease Thread Group members' adoption.

Cristib05 commented 1 month ago

Hi @wgtdkp. We have tested this application and we have noticed the application crashes when we try to obtain the dataset. Can you please share an apk with the latest code? I've noticed you have updated this PR since you have shared the initial APK. With ot-cli commissioner everything seems to work fine. Thanks!

wgtdkp commented 4 weeks ago

Hi, I am out of office before next week. I can help only after next Monday. If will be very helpful if you could upload an Android bugreport when the crash happened.

Or, you can patch this PR and follow the guide to build the app on your own.

Cristib05 commented 3 weeks ago

Hello @wgtdkp, I have attached a logcat from the app. commissioner_logcat.txt

wgtdkp commented 3 weeks ago

Thanks for the log. The crash is because your border router doesn't include a id TXT record in its mdns service. If you are using ot-br-psoix for your BR, you probably need to update your code to the latest version.

I should tolerate such issues in the demo app, but without the id of the BR, the demo won't work end to end.

Cristib05 commented 3 weeks ago

Thanks for your help! I will update and have another try.

Cristib05 commented 2 weeks ago

Hi @wgtdkp. I have included the id TXT field and I was able to perform the demo, I was able to see the message which indicated that dataset was saved in Google Play Services. I have another question, I always get an error, Failed to connect to Border Router: IO_ERROR: connect socket to peer addr = fe80::.... port = 49155 failed=-68. This happens when response to PTR query _meshcop._udp includes in additional section an AAAA record which contains link-local address. If I remove this link-local from additional section, and I only let global ipv6 address, no errors are shown.

I searched for the error message, and I've seen that the issue might be located here

wgtdkp commented 2 weeks ago

Can you share the full log of this one "Failed to connect to Border Router: IO_ERROR: connect socket to peer addr = fe80::.... port = 49155 failed=-68"? It works only if the scope id is appended to the link-local IPv6 address

And what's your Android OS version?

Cristib05 commented 2 weeks ago

Hello, I have attached the log when our BR adds the link local ipv6 adrress in additional data section. logcat_link-local.txt For test, I only have Android 10&11 versions.

wgtdkp commented 2 weeks ago

@Cristib05 Thanks for the bugreport, it's indeed the missing scope ID issue I suspected. I created a new version the APK with the fix. Can you help validate it? epskc-commissioner-app-debug-fix-lla.zip

Cristib05 commented 2 weeks ago

@wgtdkp I have tested with your new .apk file. I could see that now scope id is shown [fe80::...../%wlan0] for example. Dataset was retrieved and saved in google play services. Thanks for providing this update. Is there any possibility to see the retrieved dataset? Or this would be a security vulnerability?

wgtdkp commented 2 weeks ago

I added a "Show Dataset" button there to display the dataset. epskc-commissioner-app-debug-show-dataset.zip

Cristib05 commented 2 weeks ago

Thanks for this update! It will be useful for testing purposes. Couple of nits I've found after the last updates (maybe from my older Android version, I don't know.) 1) The list in which border routers are shown has increased its length, even though it's displaying only one border router (initially its length seemed to be dynamically adjusted based on number of elements displayed) 2) The input box for ephemeral key has now a width of only two digits. Every new entered digit is displayed, the previous one seems to be shifted to left side. Apart from those, everything seems to be fine. Thanks again for your support!

wgtdkp commented 2 weeks ago

Could you provide screenshots for the two issues?

Cristib05 commented 2 weeks ago

commissioner-ss.zip