Closed wgtdkp closed 3 months ago
Attention: Patch coverage is 76.08696%
with 11 lines
in your changes are missing coverage. Please review.
Project coverage is 72.83%. Comparing base (
79d1ddc
) to head (143953c
). Report is 1 commits behind head on main.:exclamation: Current head 143953c differs from pull request most recent head 5cb6cc8. Consider uploading reports for the commit 5cb6cc8 to get more accurate results
@abtink I am not sure if you are willing to review the ot-commissioner changes :)
In case no, please feel free to remove yourself from the pending list, I can wait for rongli :)
It's an overkill to define a dedicated class/struct for a simple
uint16_t
just for pretty print to json in HEX string.The library interface should prefer native/primitive data types for better interoperability with other languages such as java and Objective-C
This commit basically reverts the XpanId and PanId changes introduced in https://github.com/openthread/ot-commissioner/pull/202