openthread / ot-commissioner

OpenThread Commissioner, a Thread commissioner for joining new Thread devices and managing Thread networks.
https://openthread.io/
BSD 3-Clause "New" or "Revised" License
49 stars 36 forks source link

[coap] fix the code to ack the confirmable coap response rather than respond with the payload over the dtls session #278

Closed ZhangLe2016 closed 3 months ago

ZhangLe2016 commented 3 months ago

based on the CoAP protocol, when a CoAP server receives a confirmable CoAP response from another device, it should send a CoAP ACK message. It is incorrect to directly respond with the response data through the DTLS session.

wgtdkp commented 3 months ago

Could you share a link to the specific section in the CoAP RFC? I can take closer look.

ZhangLe2016 commented 3 months ago

Could you share a link to the specific section in the CoAP RFC? I can take closer look.

Hi @wgtdkp thanks a lot for your reviewing, I checked [5.2.2](https://datatracker.ietf.org/doc/html/rfc7252#section-5.2.2). Separate this part. image

ZhangLe2016 commented 3 months ago

Discussed with @wgtdkp, there is no problem on the current implementation of CoAP, I need to handle request messages from application layer. So let me close this PR.