openthread / ot-commissioner

OpenThread Commissioner, a Thread commissioner for joining new Thread devices and managing Thread networks.
https://openthread.io/
BSD 3-Clause "New" or "Revised" License
52 stars 35 forks source link

[kek-tlv] must only include KEK TLV in Joiner Finalize Response #67

Closed jwhui closed 4 years ago

jwhui commented 4 years ago

The current implementation includes the Joiner Router KEK TLV whenever the KEK is made available from mbedTLS.

https://github.com/openthread/ot-commissioner/blob/4b514a26d39ecb6b261da7b620facdfdaa0bb2dd/src/library/commissioning_session.cpp#L140-L143

However, the Joiner Router KEK TLV should only be included on Joiner Finalize Response messages.

For reference, see the commissioner implementation in openthread/openthread.