search

openthread / ot-reference-release

BSD 3-Clause "New" or "Revised" License
11 stars 26 forks source link

Support Thread 1.4 reference builds #79

Closed suveshpratapa closed 1 month ago

canisLupus1313 commented 2 months ago

@LuDuda FYI

sunytt commented 1 month ago

.github/workflows/build.yml still builds 1.3.1, could you update it to 1.4?

superwhd commented 1 month ago

@suveshpratapa It seems bumping the version of ot-commissioner is not a trivial step. There may be more actions needed to fix the CI failure: https://github.com/openthread/ot-reference-release/actions/runs/10164731867/job/28110844136?pr=79.

Can we bump it in another PR?

canisLupus1313 commented 1 month ago

@suveshpratapa The build problems of NCS are addressed here https://github.com/openthread/ot-reference-release/pull/82

superwhd commented 1 month ago

The ot-commissioner's build failure should be fixed by https://github.com/openthread/ot-commissioner/pull/291.

jwhui commented 1 month ago

The ot-commissioner's build failure should be fixed by openthread/ot-commissioner#291.

I just merged the ot-commissioner PR.

suveshpratapa commented 1 month ago

I just merged the ot-commissioner PR.

@jwhui Thank you, just incorporated into this PR. Now just need to wait for Nordic PR https://github.com/openthread/ot-reference-release/pull/82 to be merged.

jwhui commented 1 month ago

@jwhui Thank you, just incorporated into this PR. Now just need to wait for Nordic PR #82 to be merged.

Merged the Nordic PR as well.

superwhd commented 1 month ago

@suveshpratapa Since there are already some build failures and the PR includes multiple tasks (script change and bumping repos), could you consider dividing the PR into multiple ones? That should make it easier for debugging the build failures.

Maybe you can create a PR for bumping the repos and another PR for script changes.

suveshpratapa commented 1 month ago

@suveshpratapa Since there are already some build failures and the PR includes multiple tasks (script change and bumping repos), could you consider dividing the PR into multiple ones? That should make it easier for debugging the build failures.

Maybe you can create a PR for bumping the repos and another PR for script changes.

@superwhd Modified this PR to only have the script changes and split the others into their own PRs

superwhd commented 1 month ago

The hosted runner: GitHub Actions 403 lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

https://github.com/openthread/ot-reference-release/actions/runs/10216991615?pr=79

canisLupus1313 commented 1 month ago

@suveshpratapa The NCS 1.4 build fails for you because the reference configs do not exist for 1.4 yet in both Zephyr and NCS. We are working curently on adding 1.4 for now You can leave 1.3.1 ad default in builds for 1.4. It should work ok for You.

maciejbaczmanski commented 1 month ago

@suveshpratapa https://github.com/openthread/ot-reference-release/pull/85 should allow building thread 1.4 in NCS

suveshpratapa commented 1 month ago

@suveshpratapa #85 should allow building thread 1.4 in NCS

@maciejbaczmanski Can you check what could be happening? I rebased to include your merged changes and t's still failing to build NCS for 1.4.

maciejbaczmanski commented 1 month ago

@suveshpratapa #85 should allow building thread 1.4 in NCS

@maciejbaczmanski Can you check what could be happening? I rebased to include your merged changes and t's still failing to build NCS for 1.4.

error can be seen here: https://github.com/openthread/ot-reference-release/actions/runs/10404358834

System.IO.IOException: No space left on device : '/home/runner/runners/2.319.1/_diag/Worker_20240815-131230-utc.log'

So it seems like a CI issue?

jwhui commented 1 month ago

error can be seen here: https://github.com/openthread/ot-reference-release/actions/runs/10404358834

System.IO.IOException: No space left on device : '/home/runner/runners/2.319.1/_diag/Worker_20240815-131230-utc.log'

So it seems like a CI issue?

I just submitted https://github.com/openthread/ot-reference-release/pull/87, hopefully it will help.

jwhui commented 1 month ago

@suveshpratapa , I just merged #87. Can you rebase this PR and see if it helps?