search

openthread / ot-reference-release

BSD 3-Clause "New" or "Revised" License
11 stars 27 forks source link

Update ot-commissioner to latest for 1.4 reference builds #83

Closed suveshpratapa closed 3 months ago

superwhd commented 3 months ago

Please also update the changelog. Thanks!

suveshpratapa commented 3 months ago

Please also update the changelog. Thanks!

Thank you, updated it!

suveshpratapa commented 3 months ago

@jwhui Can we please get this PR merged? Thank you.

jwhui commented 3 months ago

@jwhui Can we please get this PR merged? Thank you.

@suveshpratapa , can you help resolve conflicts?

librasungirl commented 3 months ago

Suggest to update to the hash with https://github.com/openthread/ot-commissioner/pull/292 already merged, ( nice to have https://github.com/openthread/ot-commissioner/pull/293 which is close to merge), which supports secure session establishment without petition to meet ePSKc test plan's requirement

librasungirl commented 3 months ago

Suggest to update to the hash with openthread/ot-commissioner#292 already merged, ( nice to have openthread/ot-commissioner#293 which is close to merge), which supports secure session establishment without petition to meet ePSKc test plan's requirement

and maybe in this or separate PR, OpenThread repo needs update to have the mandatory changes https://github.com/openthread/openthread/pull/10524 for cert requirements

librasungirl commented 3 months ago

Suggest to update to the hash with openthread/ot-commissioner#292 already merged, ( nice to have openthread/ot-commissioner#293 which is close to merge), which supports secure session establishment without petition to meet ePSKc test plan's requirement

may update to the latest upstream with 639e627 which has the updated/new cli commands for epskc test @suveshpratapa

suveshpratapa commented 3 months ago

may update to the latest upstream with 639e627 which has the updated/new cli commands for epskc test @suveshpratapa

Thank you @librasungirl ... just made the change to update ot-commissioner to https://github.com/openthread/ot-commissioner/commits/639e627/

and maybe in this or separate PR, OpenThread repo needs update to have the mandatory changes https://github.com/openthread/openthread/pull/10524 for cert requirements

We already pushed a change recently to ot-reference-release (https://github.com/openthread/ot-reference-release/pull/84) that updates the openthread commit to 5493815, which includes the change you're talking about: https://github.com/openthread/openthread/commits/5493815/

suveshpratapa commented 3 months ago

@jwhui Can we get this merged? Thanks.