Closed Stefan-Schmidt closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Ping. First contribution here. CLA signed and Github checks are passing. Anything else I need to be aware of? Or just some patience. :-)
In commit 4e2ef143046a0c89afe6fd66acf5b7a7f35e8356 this header was added unconditionally. For my system (Yocto with musl) this results in strlcpy being redefined to __missing_strlcpy in all cases. No matter if strlcpy is available or not.
Given it is available and the nl.m4 macros detects this, the libstrlcpy.la helper is not build which results in:
netif-mgmt.c:386: more undefined references to `___missing_strlcpy' follow
Signed-off-by: Stefan Schmidt stefan.schmidt@huawei.com