Fixed stack-buffer-overflow in metric_len

nandedkarhrishi commented 3 years ago

Fixed stack-buffer-overflow in metric_len reported at https://github.com/openthread/wpantund/issues/502.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

abtink commented 3 years ago

@nandedkarhrish thanks for submitting this fix. I see CLA is failing on this PR. Can you please help check this? Thanks. https://github.com/openthread/wpantund/pull/503#issuecomment-869357939

nandedkarhrishi commented 3 years ago

@googlebot I signed it!

google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

nandedkarhrishi commented 3 years ago

@abtink maybe the failure was due to CLA signing. Signed the CLA just now.

jwhui commented 3 years ago

@abtink maybe the failure was due to CLA signing. Signed the CLA just now.

@nandedkarhrishi, @googlebot is now indicating that the commit is authored by a different author (@dot11monk). Can you ensure that the author matches your contact information or that @dot11monk has signed the Google CLA?

google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

nandedkarhrishi commented 3 years ago

@jwhui thank you for helping. The commit is authored by me alone. There are no other authors involved. As per github profile, the handle says nandedkarhrishi. Please suggest.

jwhui commented 3 years ago

@jwhui thank you for helping. The commit is authored by me alone. There are no other authors involved. As per github profile, the handle says nandedkarhrishi. Please suggest.

@nandedkarhrishi, as mentioned, the commit is showing @dot11monk as the author. See screenshot:

nandedkarhrishi commented 3 years ago

@jwhui, confirmed, the handle dot11monk belongs to me, but is connected to different account, which was almost never used. My apologies for hassle.

dot11monk commented 3 years ago

@googlebot I fixed it..

On Tue, Jun 29, 2021 at 3:00 AM google-cla[bot] @.***> wrote:

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here https://cla.developers.google.com/ to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fopenthread%2Fwpantund%2Fpull%2F503 for more info.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openthread/wpantund/pull/503#issuecomment-870058314, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5WRP5IF2TNOEMMQIQZ4G3TVDSXVANCNFSM47NGEQZA .

-- regards,

mit is god

Stefan-Schmidt commented 3 years ago

@nandedkarhrishi what @jwhui means is that you change the author of the commit to the same as you have for your signed CLA and re-push the PR. Looking at the PR it is still the dot11monk handle. Changing the git author will be a lot easier than the one for the CLA, I assume. :-)

openthread / wpantund