search

opentibia / server

An open source server for the MMORPG Tibia.
GNU General Public License v2.0
414 stars 149 forks source link

added compiler headers #59

Closed rmujica closed 7 years ago

rmujica commented 7 years ago

added compiler headers depending on which compiler is being used. this fixes a problem when trying to complile using pgsql

rmujica commented 7 years ago

Hi @ivucica , sorry for the delay. I have removed the commit about the compiler headers, I was using that because the PostgreSQL database driver used a macro (ATOI64) that I thought it was compiler-dependant. I have now changed the macro into atoll like the MySQL driver.

Thanks for your feedback! I hope to continue improving my pull requests as I develop my server further.

ivucica commented 7 years ago

Thanks for your contributions!

Unfortunately, that commit is still present in the history you're pushing into this pull request, and neither have you removed your changes in 0cc882e. See all the changes you're trying to push here: https://github.com/opentibia/server/pull/59/files

Additionally, I'll still ask you to rebase your changes.

rmujica commented 7 years ago

@ivucica sorry, it was my first time rebasing, I dropped the wrong commit. I have fixed that and commited the code I dropped.

ivucica commented 7 years ago

I've slightly misinterpreted the Github web UI, and this is and was correctly rebased.

You've correctly removed the unnecessary changes, thanks.

I would have liked to see the commit log messages more descriptive, but I'll accept this. Thank you!

rmujica commented 7 years ago

I will try to make commit messages more descriptive, thanks for your feedback!