search

opentibiabr / canary

Canary Server 13.x for OpenTibia community.
https://docs.opentibiabr.com/
GNU General Public License v2.0
374 stars 617 forks source link

Client 13 closing (crash) after saying "trade" to NPCs #1041

Closed anderkrox closed 1 year ago

anderkrox commented 1 year ago

Priority

Critical

Area

What happened?

I and several other people are having problems when talking to NPCs who buy and sell items. After saying the word "trade", client 13 has a problem and closes. It has no problems on the server terminal. This problem is probably related to the multiprotocol client 11. I'm not sure.

What OS are you seeing the problem on?

Linux, Windows

Code of Conduct

anderkrox commented 1 year ago

This problem is probably related to the multiprotocol client 11. I'm not sure.

Dengow-Matt commented 1 year ago

I tested it and it really crashes the client when talking trade to the npc

victortp commented 1 year ago

I'm also having this problem when I try to trade with the NPC Esrik. Animation2

sttibia commented 1 year ago

@victortp Are you using the client 13.16? Here is working fine. I'm not having this kind of problem on protocol 11 either. Is it any specific NPC?

victortp commented 1 year ago

@victortp Are you using the client 13.16? Here is working fine. I'm not having this kind of problem on protocol 11 either. Is it any specific NPC?

@sttibia Yes, 13.16.13209. So far, only happened when trading with Esrik.

LeoBorges18 commented 1 year ago

@victortp Are you using the client 13.16? Here is working fine. I'm not having this kind of problem on protocol 11 either. Is it any specific NPC?

@sttibia Yes, 13.16.13209. So far, only happened when trading with Esrik.

Apparently the cause is PR 516.

sttibia commented 1 year ago

You're right, I started testing with several NPCs and indeed, some of them crash. The ones that crash for me are Gorn and Pompan.

Just to help identify the error, I tested it on protocol 11 and the error doesn't occur there.

travisani commented 1 year ago

Paste the client crash log for check

sttibia commented 1 year ago

@travisani

2023-05-01, 09:00:52: News query failed: "Unrecognized event news." 2023-05-01, 09:00:56: Error while processing network packet not enough bytes (2) available at position 1489 2023-05-01, 09:00:56: "egYAUG9tcGFu1wsAADYAJgsACABiYWNrcGFjawgHAAAUAAAAAAAAACULAAMAYmFnIAMAAAUAAAAAAAAAJwsABgBiYXNrZXS2AwAABgAAAAAAAAAIjAALAGJsdWUgcXVpdmVypAYAAJABAAAAAAAAOQsABgBidWNrZXTQBwAABAAAAAAAAABlCwALAGNhbmRsZXN0aWNrLAEAAAIAAAAAAAAAmQ0ACwBjbG9zZWQgdHJhcDQIAAAYAQAASwAAAOgMAAcAY3Jvd2JhcjQIAAAEAQAAMgAAAFQoABMAZXhwZWRpdGlvbiBiYWNrcGFjawgHAABkAAAAAAAAAFUoAA4AZXhwZWRpdGlvbiBiYWcgAwAAMgAAAAAAAACbDQALAGZpc2hpbmcgcm9kUgMAAJYAAAAoAAAAYgsABABsYW1wuAsAAAgAAAAAAAAAgA0ABABwaWNrlBEAADIAAAAPAAAA6ooABgBxdWl2ZXKkBgAAkAEAAAAAAAAJjAAKAHJlZCBxdWl2ZXKkBgAAkAEAAAAAAAC7CwAEAHJvcGUIBwAAMgAAAA8AAAB9DQAGAHNjeXRoZbgLAAAyAAAACgAAAIENAAYAc2hvdmVsrA0AADIAAAAIAAAAaAsABQB0b3JjaPQBAAACAAAAAAAAAFoLAAUAd2F0Y2gyAAAAFAAAAAYAAACkDQAEAHdvcm0FAAAAAQAAAAAAAAC1DQAHAGlua3dlbGzIAAAAAAAAAAgAAACHDQAGAG1pcnJvcrYDAAAAAAAACgAAAN0MAAYAc2lja2xlGgQAAAAAAAADAAAAdw0ABQBhcnJvd0YAAAADAAAAAAAAAHYNAAQAYm9sdFAAAAAEAAAAAAAAABYNAAMAYm93HAwAAJABAABkAAAAFQ0ACABjcm9zc2Jvd6APAAD0AQAAeAAAALE9ABEAY3J5c3RhbGxpbmUgYXJyb3dLAAAAFAAAAAAAAAA9jAANAGRpYW1vbmQgYXJyb3dQAAAAZAAAAAAAAABrKAAPAGRyYWdvbiB0YXBlc3RyeegDAABQAAAAAAAAAA4/AAoAZHJpbGwgYm9sdFAAAAAMAAAAAAAAAAYDAAsAZWFydGggYXJyb3dGAAAABQAAAAAAAAAPPwAPAGVudmVub21lZCBhcnJvd0YAAAAMAAAAAAAAAPsCAA0AZmxhbWluZyBhcnJvd0YAAAAFAAAAAAAAAPkCAAsAZmxhc2ggYXJyb3dGAAAABQAAAAAAAADFHAAKAG9ueXggYXJyb3dGAAAABwAAAAAAAADDHAANAHBpZXJjaW5nIGJvbHRQAAAABQAAAAAAAAB6DQAKAHBvd2VyIGJvbHRaAAAABwAAAAAAAAANPwAOAHByaXNtYXRpYyBib2x0VQAAABQAAAAAAAAA0hwACwByb3lhbCBzcGVhcsQJAAAPAAAAAAAAAPoCAAwAc2hpdmVyIGFycm93RgAAAAUAAAAAAAAAxBwADABzbmlwZXIgYXJyb3dGAAAABQAAAAAAAADNDAAFAHNwZWFy0AcAAAkAAAADAAAAPowADQBzcGVjdHJhbCBib2x0WgAAAEYAAAAAAAAAqzcADAB0YXJzYWwgYXJyb3dGAAAABgAAAAAAAADXDAANAHRocm93aW5nIHN0YXLIAAAAKgAAAAAAAACsNwALAHZvcnRleCBib2x0UAAAAAYAAAAAAAAAqSgADgBjb3JydXB0ZWQgZmxhZ3AAAAAAAAAAvAIAAK8oAA8AaGlnaCBndWFyZCBmbGFncAAAAAAAAAAmAgAAsSgAEQBsZWdpb25uYWlyZSBmbGFnc24AAAAAAAAA9AEAAK0oAAsAemFvZ3VuIGZsYWdiAAAAAAAAAFgCAABXKAARAG1pbm90YXVyIGJhY2twYWNrOgcAAMgAAAAAAAAAVigADwBkcmFnb24gYmFja3BhY2ukBgAAyAAAAAAAAADuAAAAAAAAAAAA7gEDAAAAAAAAAHsCuwsBAA=="

victortp commented 1 year ago

@travisani

2023-05-01, 13:12:33: News query failed: "Unrecognized event news." 2023-05-01, 13:12:34: BattlEye: "Initialized (v1.249)" 2023-05-01, 13:12:34: BattlEye: "Restarting client is necessary, service isn't running properly" 2023-05-01, 13:12:34: BattlEye: "Restarting client is necessary, update required" 2023-05-01, 13:12:34: BattlEye: "Config entry: GameID tibia" 2023-05-01, 13:12:34: BattlEye: "Config entry: MasterPort 7171" 2023-05-01, 13:12:34: Request connection to gameserver "tcp://127.0.0.1:7172" (unprotected: "tcp://127.0.0.1:7172" ) requested (Charakter "Teste" ) 2023-05-01, 13:12:34: Request connection to gameserver "tcp://127.0.0.1:7172" "OTServBR-Global" 2023-05-01, 13:12:34: Connected to gameserver "tcp://127.0.0.1:7172" "OTServBR-Global" 2023-05-01, 13:12:35: News query failed: "Unrecognized event news." 2023-05-01, 13:12:39: Error while processing network packet not enough bytes (2) available at position 3126 2023-05-01, 13:12:39: "egUARXNyaWvXCwAAaQDGDAAEAGNsdWLECQAABQAAAAEAAADqDQAEAGNvYXSMCgAACAAAAAEAAADpDQAGAGphY2tldGAJAAAMAAAAAQAAAMMMAAYAZGFnZ2VytgMAAAUAAAACAAAA4A0ADQBsZWF0aGVyIGJvb3RzhAMAAAoAAAACAAAA4gwADgB0aHJvd2luZyBrbmlmZfQBAAAZAAAAAgAAADMNAAcAZG91YmxldMQJAAAQAAAAAwAAAN0MAAYAc2lja2xlGgQAAAcAAAADAAAAxAwACABoYW5kIGF4ZQgHAAAIAAAABAAAABsNAA4AbGVhdGhlciBoZWxtZXSYCAAADAAAAAQAAAAJDQAJAGJvbmUgY2x1YjwPAAAAAAAABQAAAMgMAAYAcmFwaWVy3AUAAA8AAAAFAAAAhg0ACQBzbWFsbCBheGXQBwAAAAAAAAUAAABUDQANAHdvb2RlbiBzaGllbGSgDwAADwAAAAUAAADKDAADAGF4ZaAPAAAUAAAABwAAAOcNAAwAbGVhdGhlciBsZWdzCAcAAAoAAAAJAAAA3gwACwBzaG9ydCBzd29yZKwNAAAaAAAACgAAAAgNAAwAc3R1ZGRlZCBjbHVirA0AAAAAAAAKAAAAIQ0ADQBsZWF0aGVyIGFybW9ycBcAACMAAAAMAAAAyQwABQBzYWJyZcQJAAAjAAAADAAAACINAAwAc3R1ZGRlZCBsZWdzKAoAADIAAAAPAAAALw0ADgBzb2xkaWVyIGhlbG1ldIAMAABuAAAAEAAAAGINAA4Ac3R1ZGRlZCBzaGllbGQMFwAAMgAAABAAAAAYDQAMAGNoYWluIGhlbG1ldGgQAAA0AAAAEQAAAAoNAAoAYm9uZSBzd29yZGwHAABLAAAAFAAAADANAA4Ac3R1ZGRlZCBoZWxtZXSSCQAAPwAAABQAAAAuDQANAGxlZ2lvbiBoZWxtZXQcDAAAAAAAABYAAABTDQAMAGJyYXNzIHNoaWVsZHAXAABBAAAAGQAAAOYNAAoAY2hhaW4gbGVnc6wNAABQAAAAGQAAAMwMAAcAaGF0Y2hldKwNAAAAAAAAGQAAADINAA0Ac3R1ZGRlZCBhcm1vcrwbAABaAAAAGQAAAMAMAAUAc3dvcmSsDQAAVQAAABkAAAAaDQAMAGJyYXNzIGhlbG1ldIwKAAB4AAAAHgAAANYMAAQAbWFjZdgOAABaAAAAHgAAAOQMAAYAa2F0YW5hHAwAAAAAAAAjAAAAoEUADgBzd2FtcGxpbmcgY2x1YhwMAAAAAAAAKAAAAFINAAwAcGxhdGUgc2hpZWxkZBkAAH0AAAAtAAAALA0ACgBicmFzcyBsZWdz2A4AAMMAAAAxAAAAZg0ADQBjb3BwZXIgc2hpZWxknBgAAAAAAAAyAAAA6AwABwBjcm93YmFyNAgAAAQBAAAyAAAA1QwACQBsb25nc3dvcmRoEAAAoAAAADMAAAAnDQANAHZpa2luZyBoZWxtZXQ8DwAACQEAAEIAAAAeDQALAGNoYWluIGFybW9yECcAAMgAAABGAAAAMQ0ACwBzY2FsZSBhcm1vcgQpAAAEAQAASwAAAMIMAAoAYmF0dGxlIGF4ZYgTAADrAAAAUAAAAFENAAwAc3RlZWwgc2hpZWxk9BoAAPAAAABQAAAAZw0ADQB2aWtpbmcgc2hpZWxkyBkAAAQBAABVAAAAVQ0ADQBiYXR0bGUgc2hpZWxkOBgAAAAAAABfAAAAYQ0ADgBkd2FydmVuIHNoaWVsZHwVAAD0AQAAZAAAANIMAAwAbW9ybmluZyBzdGFyGBUAAK4BAABkAAAA5Q0ACgBwbGF0ZSBsZWdziBMAAAAAAABzAAAA0wwADABjYXJsaW4gc3dvcmSgDwAA2QEAAHYAAADpDAANAGJhdHRsZSBoYW1tZXKQGgAAXgEAAHgAAAAfDQALAGJyYXNzIGFybW9yQB8AAMIBAACWAAAAGQ0ACwBpcm9uIGhlbG1ldLgLAACGAQAAlgAAAMcMAAsAc3Bpa2Ugc3dvcmSIEwAAQB8AAPAAAAAxKAALAHJlZCBsYW50ZXJuLAEAAAAAAAD6AAAAywwACgBkb3VibGUgYXhlWBsAAAAAAAAEAQAAFw0ADABzdGVlbCBoZWxtZXT4EQAARAIAACUBAAD0DAAKAG9yY2lzaCBheGWUEQAAAAAAAF4BAADFDAAHAGhhbGJlcmQoIwAAAAAAAJABAAAdDQALAHBsYXRlIGFybW9y4C4AALAEAACQAQAAwQwAEAB0d28gaGFuZGVkIHN3b3JkWBsAALYDAADCAQAAzwwACgB3YXIgaGFtbWVyNCEAABAnAADWAQAA0AwACgBmaXJlIHN3b3Jk/AgAAAAAAADoAwAAmCgACgB0d2luIGhvb2tziBMAAEwEAAAAAAAApigADQB6YW9hbiBoYWxiZXJk/CEAALAEAAAAAAAAiW8ADABleGVyY2lzZSBheGXoAwAAZAEEAAAAAACLbwAMAGV4ZXJjaXNlIGJvd+gDAABkAQQAAAAAAIpvAA0AZXhlcmNpc2UgY2x1YugDAABkAQQAAAAAAIhvAA4AZXhlcmNpc2Ugc3dvcmToAwAAZAEEAAAAAADQiQAUAGR1cmFibGUgZXhlcmNpc2UgYXhl6AMAAGhrDgAAAAAA0okAFABkdXJhYmxlIGV4ZXJjaXNlIGJvd+gDAABoaw4AAAAAANGJABUAZHVyYWJsZSBleGVyY2lzZSBjbHVi6AMAAGhrDgAAAAAAz4kAFgBkdXJhYmxlIGV4ZXJjaXNlIHN3b3Jk6AMAAGhrDgAAAAAA1okAFABsYXN0aW5nIGV4ZXJjaXNlIGF4ZegDAABAW3MAAAAAANiJABQAbGFzdGluZyBleGVyY2lzZSBib3foAwAAQFtzAAAAAADXiQAVAGxhc3RpbmcgZXhlcmNpc2UgY2x1YugDAABAW3MAAAAAANWJABYAbGFzdGluZyBleGVyY2lzZSBzd29yZOgDAABAW3MAAAAAAOEnABYAbGl6YXJkIHdlYXBvbiByYWNrIGtpdHwVAAD0AQAAAAAAALIoAA4AYnJva2VuIGhhbGJlcmTSAAAAAAAAAGQAAACoKAAQAHNwaWtlZCBpcm9uIGJhbGx9AAAAAAAAAGQAAACNLQANAEJyb2tlbiBTbGljZXKMAAAAAAAAAHgAAACwKAAbAGhpZ2ggZ3VhcmQncyBzaG91bGRlcnBsYXRlc2cAAAAAAAAAggAAAKQoABIAYm9uZSBzaG91bGRlcnBsYXRl3AAAAAAAAACWAAAArigAFwB6YW9ndW4ncyBzaG91bGRlcnBsYXRlc2cAAAAAAAAAlgAAAKUoABcAd2FybWFzdGVyJ3Mgd3Jpc3RndWFyZHN4AAAAAAAAAMgAAACqKAAWAGN1cnNlZCBzaG91bGRlciBzcGlrZXNhAAAAAAAAAEABAACMLQASAGJyb2tlbiBkcmFrZW4gbWFpbMgAAAAAAAAAVAEAAIstABEAZHJha2VuIHdyaXN0YmFuZHNOAAAAAAAAAK4BAACYKAAKAHR3aW4gaG9va3OIEwAAAAAAAPQBAACmKAANAHphb2FuIGhhbGJlcmT8IQAAAAAAAPQBAACsKAAYAHdhaWxpbmcgd2lkb3cncyBuZWNrbGFjZRwCAAAAAAAAuAsAAJIoAAsAemFvYW4gc2hvZXO8AgAAAAAAAIgTAACXKAAIAGRyYWNoYWt1cBcAAAAAAAAQJwAAlCgACQBkcmFraW5hdGEYFQAAAAAAABAnAACQKAALAHphb2FuIGFybW9yTiUAAAAAAACwNgAAkygACgB6YW9hbiBsZWdzyBkAAAAAAACwNgAAlSgAAwBzYWmIEwAAAAAAAHRAAACJLQALAHR3aWNlc2xpY2VyUEYAAAAAAABgbQAAligACwB6YW9hbiBzd29yZCQTAAAAAAAAMHUAAFMoAA4AZ3VhcmRpYW4gYm9vdHPKCAAAAAAAALiIAADBDwAMAGRyYWtlbiBib290c8QJAAAAAAAAQJwAAJEoAAwAemFvYW4gaGVsbWV0yBkAAAAAAADIrwAAgy0AEQBFbGl0ZSBEcmFrZW4gTWFpbOAuAAAAAAAAUMMAAO4A3MlyAAAAAADuAQAAAAAAAAAAewLBDAEA"

gdss commented 1 year ago

It's happening to all trade npcs.

Steps to reproduce the error: 1 - have an item with you that the npc buys 2 - hi > trade