search

opentibiabr / canary

Canary Server 13.x for OpenTibia community.
https://docs.opentibiabr.com/
GNU General Public License v2.0
374 stars 617 forks source link

Monster continues in battleList after being removed (10+ creatures in same tile) #160

Open Schiffers opened 2 years ago

Schiffers commented 2 years ago

What happened?

monsters that was in STACK still in the battle list when removed by /r

How to Reproduce?

create a script that put 10 monsters in the same SQM.. remove all with /r the last one will be in the battle list it disappear only you up or down a floor image the frog was in front of the player.

Relevant log output

No response

Attach any relevant file

No response

Version

10/12.x (10/12.x branch)

What OS are you seeing the problem on?

Windows

Code of Conduct

gerotib commented 2 years ago

@Schiffers If you spawn 10 monsters in a stack does it show all of them in battle list or couple are missing? Anyways I think that merging this pr could fix that: https://github.com/otland/forgottenserver/pull/2673

It fixes lagging player to wrong tile when there are over 10 monsters in a tile, and diseappearing of monster from battle list (which causes [ 2021-11-05 20:49:00,649 ] "updateOrCreateCreatureFromProtobuf: no creature with id 1073769968 found" in client logs) Video: https://gfycat.com/delayedrealisticgar With this pr it doesnt happen.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 120 days with no activity.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 120 days with no activity.