opentibiabr / canary

Canary Server 13.x for OpenTibia community.
https://docs.opentibiabr.com/
GNU General Public License v2.0
372 stars 613 forks source link

Wheel avatar cooldown reduction and capacity not work #2150

Open jeswilldbm opened 8 months ago

jeswilldbm commented 8 months ago

Priority

Medium

Area

What happened?

I was testing and when trying with the Master Sorcerer, it has some gems that reduce the energy wave by 1 second, when placed in the 4 available slots it correctly reduces 4 seconds of CD, but when trying with the runes that reduce the avatar by 300 seconds, it does not reduce even placing the 4 runes that do the same. image image image image image image

On the other hand, when adding a gem that adds capacity, it only increases by 1 or two points, when it should assign another amount, here I show the wheel without any gem as a reference: image Now I will add a "1000" capacity bonus: image Even if I add 1000 capacity, I only add 10 points.

This was tested in the latest available version of canary main downloaded today 01/25/2024 and without anything custom, as it comes as is.

What OS are you seeing the problem on?

Windows

Code of Conduct

Mirkaanks commented 8 months ago

We have a base, with time we will be doing work as well.

dudantas commented 8 months ago

Gems fix: #2152 Please update your issue.

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 120 days with no activity.

luanluciano93 commented 2 months ago

confirmed, capacity not work

uint32_t Player::getCapacity() const {
    if (hasFlag(PlayerFlags_t::CannotPickupItem)) {
        return 0;
    } else if (hasFlag(PlayerFlags_t::HasInfiniteCapacity)) {
        return std::numeric_limits<uint32_t>::max();
    }
    return capacity + bonusCapacity + varStats[STAT_CAPACITY] + m_wheelPlayer->getStat(WheelStat_t::CAPACITY);
}