SkillTries gain presents progression error

rokamdev commented 7 months ago

Priority

High

Area

[ ] Datapack
[X] Source
[ ] Map
[ ] Other

What happened?

Any SkillTries progress (club, sword, axe, distance, fist, fishing, except Magic level) presents a progression error. It is always being added to the skill % gain in "whole" numbers (99%, 97%, 95%, ...), never "broken" % (98.76%, 96.62%, 94.26%, ...), however after logging out and logging in, the last advance is changed to % broken. The problem itself does not seem to be impactful, however it disregards the premium dummy, since the difference between a free dummy and a premium is 0.1x. Although it is not a considerable difference, the skill gains in both dummies are identical, making the premium dummy unfeasible for any SkillTries training. This problem happens with both exercise training and conventional training. Reinforcing that Magic Level training does not fit this problem, as it is not included in SkillTries and the calculation is based on mana expenditure. Images show the before and after progress after logging out and logging in. I believe the problem is related to a "uint_" added in the wrong location, but I searched the files, made some changes to test and the problem persists, beyond my ability to resolve. =/