error in damage wand/rods with the chain system

jeswilldbm commented 6 months ago

Priority

Low

Area

[X] Datapack
[X] Source
[ ] Map
[ ] Other

What happened?

If the chain system is activated, the damage propagates in a chain correctly, but I see a problem, the damage of all the wands/rods is basically the same... so having a "snakebite rod" or a "grand sanguine rod" doesn't seem to have any differences. I have tested with the ms and it works the same, it would be ideal for the chain system to work in such a way that the damage of the wands/rods is the same as what one can configure for each wand individually, so, thus, a "snakebite rod" would chain hit with lower damage than with a "grand sanguine rod". I attach a sample: damage ed and ms2

A possible suggestion would be to have a way to activate the chain system for a specific type of weapon or independently, for example, to activate it only for wands/rods, or only for ek, just as it is blocked for bows/crossbows. I'm not an expert in it and I don't know the difficulty in doing something like that.

For this test, use the latest version available

What OS are you seeing the problem on?

Windows

Code of Conduct

[X] I agree to follow this project's Code of Conduct

dudantas commented 6 months ago

Are the "snakebite rod" and the "grand sanguine rod" doing the same average damage? I thought I added it to consider the min and max damage of each one. Isn't that your impression? Since you consider the level and magic level as well?

jeswilldbm commented 6 months ago

Currently, it considers the level and the magic level, however, I don't see any differences in having one wand or the other... so the damage in principle should be based on what is configured in items.xml for example the snakebite rod has a damage: snakebiterod

and the grand sanguine rod:

So I would say that it is based on the independent damage of each wand/rod, so that if someone wants to edit the damage, just change the values that appear on the wand and thus they will have a stronger weapon. With the current configuration, I see the damage very similar and as an example, I edited the grand sanguine rod and raised the damage like this: I keep hitting the same thing, so it doesn't consider that damage.