opentibiabr / canary

Canary Server 13.x for OpenTibia community.
https://docs.opentibiabr.com/
GNU General Public License v2.0
371 stars 611 forks source link

Monsters not appearing (visualy) on map next to player when spawning #2479

Closed Mifuno closed 6 months ago

Mifuno commented 6 months ago

Priority

Low

Area

What happened?

Version: 13.32 Some monsters when respawning do not appear on the map, if the player stands in the screen. If the player would touch such SQM it would cause a client crash. If the players would change the floor or leave the area and return the monster would appear correctly on the screen, howerver the situation will repeat.

Changing the monster appearance to a different one (of a working monster( does not solve the issue. Chaning the monster name to a different one does not solve the issue. Moving the monster spawn point does not solve the issue.

Right now I was able to find 2 such monsters:

Crash log when moving to the SQM where the invisible monster stays 2024-03-21, 06:42:29: "updateOrCreateCreatureFromProtobuf: no creature with id 1342274665 found" 2024-03-21, 06:42:29: "updateOrCreateCreatureFromProtobuf: no creature with id 1342274666 found" 2024-03-21, 06:42:34: Error while processing network packet No creature found at coordinate(33883,31250,7)/position(3). Found appearance was FoundAppearanceInstance::AppearanceType( 35387 ), FoundAppearanceInstanceTypeId( class tibia::appearances::TWorldMapAppearanceInstance ) 2024-03-21, 06:42:34: "bVuEEnoHA1qEEnoHaBWKAP8VivBA90AA/3SL9InxifBA9kAA/2VA9kAA/xSK9EAA/xuKAP8WihQTAP90IKcJAAD/dSAA/3QgYgDhSgFQZABCBQJgTmABAAD/AKAAAQQBAwAAAAEA/wAAAP91IKByAP91IAD/dSAA//cRExMF/00VAP90IOMGAP96IAD/dSAA/3QgTBMA/3UgAP90IAD/dCA1E1X/"

GIF that show's the issue. IglaTest13_30_ahpxdeIuFJ

What OS are you seeing the problem on?

Linux

Code of Conduct

dguprado commented 6 months ago

Yes it is really happening. I'm using the latest canary revision. I follow the step, and I have the same result.

dudantas commented 6 months ago

There are some discrepancies in your explanation. It only happens with god, the reason is that god has the "ignore monsters" flag, which means it doesn't skip the blockable's continue here:

https://github.com/opentibiabr/canary/blob/198f79b7e135b5d60d6f93319f80802e48aad1ec/src/creatures/monsters/spawns/spawn_monster.cpp#L159 https://github.com/opentibiabr/canary/blob/198f79b7e135b5d60d6f93319f80802e48aad1ec/src/creatures/monsters/spawns/spawn_monster.cpp#L252

So, this only happens with god, since with a normal player it will continue and it will not spawn the monster.

odisk777 commented 6 months ago

Same #2457