Closed joelslamospersson closed 1 month ago
I suggest you create a pull request. It will be faster and easier to test and modify, if necessary.
Think I created a pull request now, unsure how to do it.
I suggest you create a pull request. It will be faster and easier to test and modify, if necessary.
Think I created a pull request now, unsure how to do it.
Contributing to public repositories is a bit different from contributing to your own, but it's still easy. You need to:
For future contributions, you need to keep your fork updated by syncing it.
@joelslamospersson I don't understand the purpose of the changes, what are you correcting? What wasn't working?
you just changed the logic of the content of creatureevent-commander_kills to the script itself, but I can't understand what that did.
Priority
Low
Area
What happened?
Since Drume is not working as real tibia should, here's a re-work and updated script version. I'd apprechiate if someone we're to test it out and try to bug it. If any issues, I'll have it fixed.
Setup: Change code to the new one, file location: canary-main/otservbr-global/scripts/quests/the_order_of_lion/action-drume.lua
Register this in lion and usurper
Location for monsters: canary-main/data-otservbr-global/monster/quests/the_order_of_lion
For Lion monster.events = { "lionCommanderDeath" }
For Usurper (Should already be inside), double check it. monster.events = { "usurperCommanderDeath" }
What OS are you seeing the problem on?
Linux
Code of Conduct