opentibiabr / canary

Canary Server 13.x for OpenTibia community.
https://docs.opentibiabr.com/
GNU General Public License v2.0
356 stars 590 forks source link

Forge fusion convergence is wrong #2718

Open luancolombo opened 2 months ago

luancolombo commented 2 months ago

Priority

Low

Area

What happened?

The forge fusion with convergence is not correct, because when you fuse need to be slot to slot, armor to armor, legs to legs. When you use transfer with convergence is correct to be to any slot.

erroforge

What OS are you seeing the problem on?

Linux, Windows

Code of Conduct

isbjornlite commented 2 months ago

change this line : if (itemClassification == 4) { getForgeInfoMap(item, convergenceItemsMap[item->getClassification()]); }

to this

if (itemClassification == 4) { getForgeInfoMap(item, convergenceItemsMap[item->getSlotPosition()]); }

luancolombo commented 2 months ago

change this line : if (itemClassification == 4) { getForgeInfoMap(item, convergenceItemsMap[item->getClassification()]); }

to this

if (itemClassification == 4) { getForgeInfoMap(item, convergenceItemsMap[item->getSlotPosition()]); }

So, I did change this line with this PR #2521 , but this line change fusion and transfer convergence

commit

murilo09 commented 2 weeks ago

PR #2521 did not fixed the issue

Explaining the Convergence System: https://tibia.fandom.com/wiki/Equipment_Upgrade#Convergence_Fusion https://tibia.fandom.com/wiki/Equipment_Upgrade#Convergence_Transfer