search

opentibiabr / canary

Canary Server 13.x for OpenTibia community.
https://docs.opentibiabr.com/
GNU General Public License v2.0
364 stars 597 forks source link

players spans in position of death with no corpse after death #2735

Closed pasturryx closed 2 months ago

pasturryx commented 3 months ago

Priority

Low

Area

What happened?

A bug happened!

when player dies instead of the appear in temple after death it appears in death position with no corpse you gotta re log in order to be teleported to temple an appear with body

What OS are you seeing the problem on?

Windows

Code of Conduct

Aerwix commented 3 months ago

Are you using OTC or Tibia 12-13 client (Cipsoft) I can confirm this bug exist but not sure if it's related to OTC Mehah or Canary itself 🤔

luanluciano93 commented 3 months ago

Você está usando o cliente OTC ou Tibia 12-13 (Cipsoft)? Posso confirmar que esse bug existe, mas não tenho certeza se está relacionado ao OTC Mehah ou ao próprio Canary 🤔

Is there an error in the otc console?

Aerwix commented 3 months ago

It's happening only in OTC Mehah https://gyazo.com/b06c6ba52fe416cd0756405bf788fa59

ERROR: ProtocolGame parse message exception (6700 bytes, 298 unread, last opcode is 0x02 (2), prev opcode is 0xae (174)): unhandled opcode 2
Packet has been saved to packet.log, you can use it to find what was wrong. (Protocol: 1100)
ERROR: ProtocolGame parse message exception (6700 bytes, 298 unread, last opcode is 0x02 (2), prev opcode is 0xae (174)): unhandled opcode 2
Packet has been saved to packet.log, you can use it to find what was wrong. (Protocol: 1100)
ERROR: invalid thing type client id 0 in category 4
ERROR: invalid thing type client id 0 in category 4
ERROR: invalid thing type client id 0 in category 4
ERROR: invalid thing type client id 0 in category 4
ERROR: invalid thing type client id 0 in category 4
ERROR: invalid thing type client id 0 in category 4
ERROR: invalid thing type client id 0 in category 4
ERROR: invalid thing type client id 0 in category 4
ERROR: invalid thing type client id 0 in category 4
ERROR: invalid thing type client id 0 in category 4
ERROR: invalid thing type client id 0 in category 4
ERROR: ProtocolGame parse message exception (6700 bytes, 299 unread, last opcode is 0xad (173), prev opcode is 0xe8 (232)): InputMessage eof reached
Packet has been saved to packet.log, you can use it to find what was wrong. (Protocol: 1100)

ProtocolGame parse message exception (8401 bytes, 1842 unread, last opcode is 0xb0 (176), prev opcode is 0xe8 (232), proto: 1100): InputMessage eof reached
ProtocolGame parse message exception (6946 bytes, 299 unread, last opcode is 0xaf (175), prev opcode is 0xe8 (232), proto: 1100): InputMessage eof reached

I just tested in OTCv8 and it's working fine 🤔

luanluciano93 commented 3 months ago

Is there this error if you use otc mehah in version 13.32?

majestyotbr commented 2 months ago

https://github.com/mehah/otclient/commit/f8cfb33fae627dc23f6b94ef4b90d5b0204ebe36

Aerwix commented 2 months ago

This bug persist :( https://streamable.com/1f3ju4

Packet.log

ProtocolGame parse message exception (34238 bytes, 0 unread, last opcode is 0x9f (159), prev opcode is 0xf5 (245), proto: 1100): InputMessage eof reached
ProtocolGame parse message exception (33186 bytes, 0 unread, last opcode is 0x9f (159), prev opcode is 0xf5 (245), proto: 1100): InputMessage eof reached
ProtocolGame parse message exception (54941 bytes, 0 unread, last opcode is 0x9f (159), prev opcode is 0xf5 (245), proto: 1100): InputMessage eof reached
ProtocolGame parse message exception (33143 bytes, 0 unread, last opcode is 0x9f (159), prev opcode is 0xf5 (245), proto: 1100): InputMessage eof reached
ProtocolGame parse message exception (29446 bytes, 0 unread, last opcode is 0x9f (159), prev opcode is 0xf5 (245), proto: 1100): InputMessage eof reached
ProtocolGame parse message exception (46206 bytes, 0 unread, last opcode is 0x9f (159), prev opcode is 0xf5 (245), proto: 1100): InputMessage eof reached
ProtocolGame parse message exception (33143 bytes, 0 unread, last opcode is 0x9f (159), prev opcode is 0xf5 (245), proto: 1100): InputMessage eof reached
ProtocolGame parse message exception (48481 bytes, 0 unread, last opcode is 0x9f (159), prev opcode is 0xf5 (245), proto: 1100): InputMessage eof reached
ProtocolGame parse message exception (33143 bytes, 0 unread, last opcode is 0x9f (159), prev opcode is 0xf5 (245), proto: 1100): InputMessage eof reached
ProtocolGame parse message exception (33143 bytes, 0 unread, last opcode is 0x9f (159), prev opcode is 0xf5 (245), proto: 1100): InputMessage eof reached
ProtocolGame parse message exception (44694 bytes, 0 unread, last opcode is 0x9f (159), prev opcode is 0xf5 (245), proto: 1100): InputMessage eof reached
ProtocolGame parse message exception (33143 bytes, 0 unread, last opcode is 0x9f (159), prev opcode is 0xf5 (245), proto: 1100): InputMessage eof reached
ProtocolGame parse message exception (33143 bytes, 0 unread, last opcode is 0x9f (159), prev opcode is 0xf5 (245), proto: 1100): InputMessage eof reached
ProtocolGame parse message exception (47097 bytes, 0 unread, last opcode is 0x9f (159), prev opcode is 0xf5 (245), proto: 1100): InputMessage eof reached

Also seems some messages aren't showed properly otclient.log

image

Im trying to send all possible info x.x

pasturryx commented 2 months ago

the bug is still present why was this closed'?

ericcobblepot commented 2 months ago

Why do you have the habit of making pull requests without verifying if the problem is fixed or closing issues without testing the solution?

@elsongabriel

image

me test, in the latest versions of each repo

13.32 and 1100 image

according to aewix it works on v8 but in mehah error occurs (this error does not occur in any version of tfs in mehah)

kokekanon commented 2 months ago

delete this if v8

https://github.com/opentibiabr/canary/blob/main/src/server/network/protocol/protocolgame.cpp#L927

proof that it works :

https://github.com/user-attachments/assets/07d31884-967e-45c9-b56e-03d11e91cdb7

test in :

client otc mehah13.32. client otc mehah 11.00 client clipsoft

work

idk in v8

majestyotbr commented 2 months ago

Fixed by #2776.