search

opentibiabr / canary

Canary Server 13.x for OpenTibia community.
https://docs.opentibiabr.com/
GNU General Public License v2.0
384 stars 637 forks source link

fix: lua getNumber overflow with "MoveEvent::EquipItem" function #3136

Closed dudantas closed 1 week ago

dudantas commented 1 week ago

Fixed overflow with "MoveEvent::EquipItem" and added imbuement shrine to canary temple

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Regeton5306 commented 1 week ago

After adding this, it makes it impossible to pick things up from the ground. Anything I drop on the ground can no longer be picked up again.

dudantas commented 1 week ago

After adding this, it makes it impossible to pick things up from the ground. Anything I drop on the ground can no longer be picked up again.

Are you sure you tested this correctly? I couldn't reproduce what you said, I tested it and everything is ok. Also, the if I changed only deals with the reward chest/boss corpse, there would be no way to bug other behaviors.

Regeton5306 commented 1 week ago

After adding this, it makes it impossible to pick things up from the ground. Anything I drop on the ground can no longer be picked up again.

Are you sure you tested this correctly? I couldn't reproduce what you said, I tested it and everything is ok. Also, the if I changed only deals with the reward chest/boss corpse, there would be no way to bug other behaviors.

My base is clean, in fact, I downloaded it about a week ago and I have been adding every update they have merged. I just tried this one and I hadn't noticed until I threw the things I had on the ground and tried to pick them up, but it didn't let me. It just said 'sorry, not possible.' Then I remembered that the only thing I had done was add this, so I reverted the changes, recompiled, and it let me pick them up again. I don't understand.

dudantas commented 6 days ago

After adding this, it makes it impossible to pick things up from the ground. Anything I drop on the ground can no longer be picked up again.

Are you sure you tested this correctly? I couldn't reproduce what you said, I tested it and everything is ok. Also, the if I changed only deals with the reward chest/boss corpse, there would be no way to bug other behaviors.

My base is clean, in fact, I downloaded it about a week ago and I have been adding every update they have merged. I just tried this one and I hadn't noticed until I threw the things I had on the ground and tried to pick them up, but it didn't let me. It just said 'sorry, not possible.' Then I remembered that the only thing I had done was add this, so I reverted the changes, recompiled, and it let me pick them up again. I don't understand.

Maybe it was compilation garbage, the change in the source of this pull request is not even relevant, it does not change the behavior of anything, it just improves the log to identify which function is causing the error.