search

opentibiabr / otservbr-global-archived

Archived, read-only repository. New repository: https://github.com/opentibiabr/otservbr-global
GNU General Public License v2.0
331 stars 335 forks source link

BUG: targeted spells are treated like item throwing #2665

Closed Zbizu closed 3 years ago

Zbizu commented 3 years ago

Description

Targeted spells (missile runes, strike spells like exori vis) can be cast through wall when there are no ground tiles/obstacles above them. The bug was discovered in clean TFS. This repository has identical code in these functions of combat.cpp so it's very likely bugged here too.

more details: otland/forgottenserver#3497

Steps to reproduce

  1. go to some open area (eg. desert)
  2. build some wall with /i
  3. spawn a rat
  4. cast exori vis from the other side of the wall

Expected behavior

"Destination is out of reach." (it fires through wall instead)

Environment

tfs, possible to reproduce here as well

my game client goes all black when I attempt to take a screenshot, but you can use ground floor of black knight villa (the bench behind a broken wall) for testing - in rl you can throw items there, but not spells.

Zbizu commented 3 years ago

my bad, ran executable compiled from other branch, sorry