opentibiabr / otservbr-global-archived

Archived, read-only repository. New repository: https://github.com/opentibiabr/otservbr-global
GNU General Public License v2.0
331 stars 333 forks source link

Looting of Crazed Summer Rearguards #372

Closed Davenorthern closed 5 years ago

Davenorthern commented 5 years ago

Describe the bug When trying to open a dead crazed summer rearguard, the client shuts down and logs the player out.

To Reproduce Go to the court of summer. Kill a crazed rearguard. Open the corpse.

Expected behavior The body should open and display the loot.

Screenshot (3)

FakeShinoda commented 5 years ago

Which client version are you using ? Client 11 and 12 i checked and its fine

Davenorthern commented 5 years ago

Im using client 11. Wierd, i'll try again tomorrow 😃

Den 9 aug. 2019 12:00 fm skrev Rick notifications@github.com:

Which client version are you using ? Client 11 and 12 i checked and its fine

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/opentibiabr/OTServBR-Global/issues/372?email_source=notifications&email_token=AMTEFNV6X73AKVRJG2B3WE3QDSJPFA5CNFSM4IKOSLM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD35AVCY#issuecomment-519703179, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMTEFNUTGFD4CPE6JWBSO4LQDSJPFANCNFSM4IKOSLMQ.

oualid6496 commented 5 years ago

Yea your client crashes because there is nothing in items.xml of that body so when you open it your client crashes. I can add it later when the team is done with the summer update.

oualid6496 commented 5 years ago

You can add this in items.xml as a temporary fix I'm not sure what the name of the body is or the container size but it will be added later.


    <item id="34712" article="a" name="elf remains">
        <attribute key="decayTo" value="0" />
        <attribute key="duration" value="300" />
        <attribute key="corpseType" value="blood" />
    </item>
    <item id="34713" article="a" name="elf remains">
        <attribute key="containerSize" value="20" />
        <attribute key="decayTo" value="34712" />
        <attribute key="duration" value="300" />
        <attribute key="corpseType" value="blood" />
    </item>
    <item id="34714" article="a" name="elf remains">
        <attribute key="containerSize" value="20" />
        <attribute key="decayTo" value="34713" />
        <attribute key="duration" value="300" />
        <attribute key="corpseType" value="blood" />
    </item>
    <item id="34715" article="a" name="elf remains">
        <attribute key="containerSize" value="20" />
        <attribute key="decayTo" value="34714" />
        <attribute key="duration" value="300" />
        <attribute key="corpseType" value="blood" />
    </item>
    <item id="34716" article="a" name="elf remains">
        <attribute key="decayTo" value="0" />
        <attribute key="duration" value="300" />
        <attribute key="corpseType" value="blood" />
    </item>
    <item id="34717" article="a" name="elf remains">
        <attribute key="containerSize" value="20" />
        <attribute key="decayTo" value="34716" />
        <attribute key="duration" value="300" />
        <attribute key="corpseType" value="blood" />
    </item>
    <item id="34718" article="a" name="elf remains">
        <attribute key="containerSize" value="20" />
        <attribute key="decayTo" value="34717" />
        <attribute key="duration" value="300" />
        <attribute key="corpseType" value="blood" />
    </item>
    <item id="34719" article="a" name="elf remains">
        <attribute key="containerSize" value="20" />
        <attribute key="decayTo" value="34718" />
        <attribute key="duration" value="300" />
        <attribute key="corpseType" value="blood" />
    </item>```
Davenorthern commented 5 years ago

Awesome, you're a fricken legend mate

Den 9 aug. 2019 9:49 fm skrev Oualid6496 notifications@github.com:

You can add this in items.xml as a temporary fix I'm not sure what the name of the body is or the container size but it will be added later.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/opentibiabr/OTServBR-Global/issues/372?email_source=notifications&email_token=AMTEFNTHACYRFYI2V2USZLLQDUOQLA5CNFSM4IKOSLM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3542DA#issuecomment-519818508, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMTEFNWXH5XH4X7UWN7JFZ3QDUOQLANCNFSM4IKOSLMQ.

EPuncker commented 5 years ago

no debug here but I'll add the corpse by @oualid6496 , I suggest you to use client 12, always use the latest client when testing new content, maybe the client 11 doesn't have some item sprite

oualid6496 commented 5 years ago

No don't that was just a temporary fix for Davenorthern the name of the body and containersize are probably not right also these are just the bodys of the summer elfs the same problem is with the ice elfs. I did reproduce this bug on client 10.

EPuncker commented 5 years ago

No don't that was just a temporary fix for Davenorthern the name of the body and containersize are probably not right also these are just the bodys of the summer elfs the same problem is with the ice elfs. I did reproduce this bug on client 10.

seems like the .spr file from client 10 didn't have the sprites then :P that is how they should look like as off latest tibia 12 assets converted to spr file: 2019-08-17 13_47_12-Window

can you provide bodies items.xml for ice elf as well? even if its only temporary :P better than nothing

oualid6496 commented 5 years ago

hmm okay well then for the ice elfs it would be

<item id="34760" article="a" name="elf remains">
    <attribute key="containerSize" value="20" />
    <attribute key="decayTo" value="34762" />
    <attribute key="duration" value="300" />
    <attribute key="corpseType" value="blood" />
</item>
<item id="34761" article="a" name="elf remains">
    <attribute key="containerSize" value="20" />
    <attribute key="decayTo" value="34765" />
    <attribute key="duration" value="300" />
    <attribute key="corpseType" value="blood" />
</item>
<item id="34762" article="a" name="elf remains">
    <attribute key="containerSize" value="20" />
    <attribute key="decayTo" value="34763" />
    <attribute key="duration" value="300" />
    <attribute key="corpseType" value="blood" />
</item>
<item id="34763" article="a" name="elf remains">
    <attribute key="containerSize" value="20" />
    <attribute key="decayTo" value="34764" />
    <attribute key="duration" value="300" />
    <attribute key="corpseType" value="blood" />
</item>
<item id="34764" article="a" name="elf remains">
    <attribute key="decayTo" value="0" />
    <attribute key="duration" value="300" />
    <attribute key="corpseType" value="blood" />
</item>
<item id="34765" article="a" name="elf remains">
    <attribute key="containerSize" value="20" />
    <attribute key="decayTo" value="34766" />
    <attribute key="duration" value="300" />
    <attribute key="corpseType" value="blood" />
</item>
<item id="34766" article="a" name="elf remains">
    <attribute key="containerSize" value="20" />
    <attribute key="decayTo" value="34767" />
    <attribute key="duration" value="300" />
    <attribute key="corpseType" value="blood" />
</item>
<item id="34767" article="a" name="elf remains">
    <attribute key="decayTo" value="0" />
    <attribute key="duration" value="300" />
    <attribute key="corpseType" value="blood" />
</item>
oualid6496 commented 5 years ago

Btw saw at the summer elfs part all the way down ''' that shouldn't be there

EPuncker commented 5 years ago

thanks, also I've created a new thread with updated clients on otland, just waiting for it to be approved, so people can use them and stop getting debugs

EPuncker commented 5 years ago

my updated client thread was not accepted on otland, we need to wait the good will of developers now to have an updated .spr and asset files for the tools repository then...

gpedro commented 5 years ago

The @MajestyOTBR already update the client last night.

majestyotbr commented 5 years ago

I'll upload and update clients 10 and 12 on tools repository.

majestyotbr commented 5 years ago

Updated clients 10 and 12 on tools repository.