opentibiabr / otservbr-global

OTServBR-Global datapack was migrated to Canary repository: https://github.com/opentibiabr/canary
GNU General Public License v2.0
143 stars 162 forks source link

Addoner/ if you have a bug report it so i can fix it #720

Closed Alissonlv123 closed 2 years ago

Alissonlv123 commented 2 years ago

Description

I hope you like it, there may be some bug, more test and good use

Behaviour

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist

lgrossi commented 2 years ago

Hi Alisson, thanks for contributing. Unfortunately, a 2k+ line script is a bit too much for us to accept.

Also, there are some indentation issues, an abuse of global variables, what is an anti pattern and a few other minor adjusts needed.

If you could split this script in smaller pieces, preferably per context/need, and adjust general formatting, that would be great. Then, re-create the PR with the changes so we can review and, perhaps, aprove it.

For now I'll close this PR. Thanks again.