Fix items ids and npc player:getName function, add water pipe action

[Austerror]

Description

Minor changes to several files.

Behaviour

Actual

1. NPC Hanna doesn't buy Wedding Ring or White Pearl.

   • Items are not in trade list as sellable.

2. Giant Shimmering Pearl is named incorrectly in hanna.lua npcConfig.shop

   • brown shimmering pearl
   • green giant shimmering pearl

Expected

NPC Hanna should buy Wedding Ring and White Pearl. Both giant shimmering pearls should be named 'giant shimmering pearl'

Fixes

1. Edit hanna.lua to include a sell value for wedding ring and white pearl of 100gold and 160gold respectively in npcConfig.shop.
2. Edit hanna.lua to change the itemName of both giant shimmering pearls to their correct name, 'giant shimmering pearl'.

Type of change

Please delete options that are not relevant.

• [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

• [X] Opened trade dialogue with NPC Hanna and confirmed that she would buy wedding ring and white pearl.
• [x] Opened trade dialogue with NPC Hanna and viewed both giant shimmering pearls to confirm they were returning the correct name, 'giant shimmering pearl'.

Behaviour

Actual

1. NPC Yasir does not buy the correct wild flowers item
2. NPC Yasir does not buy the correct heaven blossem item

Expected

NPC Yasir should buy the wild flowers item (clientId 25691) for 120gold and heaven blossom (clientId 5921) for 50gold.

Fixes

1. Edit yasir.lua and change the npcConfig.shop items, wild flower from clientId 25684 to 25691, and heaven blossom from clientId 3657 to 5921.

Type of change

Please delete options that are not relevant.

• [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

• [X] Opened trade dialogue with NPC Yasir and confirmed he buys the correct wild flowers (as dropped by Feyrist mobs), and buys correct heaven blossom as dropped by monster Elf.

Behaviour

Actual

1. The teleport into The Horned Fox boss room does not work,

Expected

After killing 5,000 minotaurs for Budrik, and completing the quest, you should have access to The Horned Fox boss room.

Fixes

1. Edit data\scripts\movements\quests\killing_in_the_name_of\boss.lua and change storage value for bossNmae, The Horned Fox from 17522 to 14896. This change required the least amount of file editing and does not break any current progress.

Type of change

Please delete options that are not relevant.

• [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

• [X] After completing the quest killing 5,000 minotaurs for Budrik in Killing In the Name Of, was able to enter the teleport and confront The Horned Fox boss.

Behaviour

Actual

1. NPC Padreia refers to the player as |PLAYERNAME| when asking for a mission, instead of the actual player name.

Expected

NPC Padreia should refer to the players name when the player asks for a mission.

Fixes

1. Edit padreia.lua and replace |PLAYERNAME| with ' .. player:getName() .. '

Type of change

Please delete options that are not relevant.

• [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

• [X] Opened dialogue with NPC Padreia and asked for a mission, Padreia correctly returned player name instead of |PLAYERNAME|.

Behaviour

Actual

1. NPC Yaman does not buy the correct ankh item (clientId 3077).

Expected

1. Players should be able to sell item ankh (clientId 3077) to NPC Yaman for 100gold.

Fixes

1. Edit data\npc\yaman.lua and change clientId for ankh, in npcConfig.shop from 3214 to 3077.

Type of change

Please delete options that are not relevant.

• [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

• [X] Opened a trade dialogue with NPC Yaman and confirmed was able to sell item ankh (as dropped by, for eg, monster monk) for 100gold.

Behaviour

Actual

1. Monster Undead Elite Gladiator has incorrect drop rates.

Expected

Monster Undead Elite Gladiator drop rates should be different to what is occurring.

Fixes

1. Edit undead_elite_gladiator.lua and change chance value to accurately reflect the drop % from the wiki.

Type of change

Please delete options that are not relevant.

• [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

• [X] Confirmed that drop rates appeared to change and reflect more closely that of the wiki.

Behaviour

Actual

1. All water pipe items (2974,2980,21323) are not associated with any action for their use (smoke).

Expected

Using any of the water pipe items (2974,2980,21323) should result in a POFF at the location of the water pipe.

Fixes

1. Authored a new file in data\scripts\actions\other\water_pipe.lua

Type of change

Please delete options that are not relevant.

• [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested

• [X] Used each of the three water pipes, both in backpack and on ground, confirmed the POFF occurs each time, and at the location of the water pipe.

Test Configuration:

• Server Version: 1.4.0
• Client: 12.86
• Operating System: Windows Server 2012 R2

Checklist

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I checked the PR checks reports
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works