opentimestamps / java-opentimestamps

Other
40 stars 31 forks source link

Bitcoin verification failed: JSONObject["merkleroot"] not found #17

Closed yurikilian closed 6 years ago

yurikilian commented 6 years ago

Hi,

This exception occurs when opentimestamps tries get info at https://btc-bitcore1.trezor.io/api. Looking into the response it gaves me HTTP 200 with: Blockbook - blockchain indexer for TREZOR wallet https://trezor.io/. Do not use for any other purpose.

Is this response returning because the block wasn`t found?

Assuming that, should we ignore this error like javascript lib or exclude this url from code?

Thank you.

RCasatta commented 6 years ago

They probably switched to another API, the best thing one can do is using a local bitcoin node, in this way opentimestamps query the local node about blockchain information.

In the case the user haven't a local node, the lib try to ask different blockexplorer for blockchain information so in some cases a single explorer failing is not a problem (and you can ignore the exception)

yurikilian commented 6 years ago

Can it be merged?

RCasatta commented 6 years ago

Could you please fix the indentation?

yurikilian commented 6 years ago

Fixed.

RCasatta commented 6 years ago

merged