search

opentimestamps / java-opentimestamps

Other
40 stars 32 forks source link

Stamp method - number of calendars (-m) parameter behavior does not reflect according another opentimestamps client libraries #20

Open yurikilian opened 6 years ago

yurikilian commented 6 years ago

https://github.com/opentimestamps/java-opentimestamps/blob/1f900aa21ab97393eb98736da587f4d4c481f107/src/main/java/com/eternitywall/ots/OpenTimestamps.java#L233

Considering the python and javascript client libraries, when the number of the calendars (-m) parameter is used and one calendar isn't available the client should send the stamp to another calendars and not stop at first one (e.g. using -m 1).

What behavior should be elected?

Thank you

yurikilian commented 6 years ago

Currently the client stops stamp when the count is equal m and if the calendar off another public calendar aren't used.

RCasatta commented 5 years ago

The python impl should be considered the reference one

Considering the python and javascript client libraries, when the number of the calendars (-m) parameter is used and one calendar isn't available the client should send the stamp to another calendars and not stop at first one (e.g. using -m 1).

The client shouldn't stop at the first error for sure, at a first glance the code you are linking doesn't stop at first error, or am I missing something?