zzxming commented 1 month ago

PR

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our Commit Message Guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #61

What is the new behavior?

paste correct format about line-height / text-indent / font-size / font-style / list.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Summary by CodeRabbit

New Features
- Introduced new attributors for text styling: Font Size, Font Style, Line Height, and Text Indent, enhancing text formatting options in the editor.
- Added a new attribute for table cells to support list functionalities.
Bug Fixes
- Improved HTML management in the editor to ensure content remains in sync with user edits.
Refactor
- Streamlined code for managing text styles by centralizing update logic and removing outdated configurations.
Chores
- Updated module registration to reflect new styling capabilities and improved organization.

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes introduced in this pull request focus on enhancing the functionality of the Fluent Editor by adding new attributors for text styling, such as font size, font style, line height, and text indent. Additionally, the management of inner HTML in the editor is improved through the introduction of a reactive reference and an update function. Some deprecated configurations related to font settings are removed, indicating a shift towards a more modular and dynamic approach to styling.

Changes

File Path	Change Summary
`packages/docs/fluent-editor/demos/get-html.vue`	Added `articleRef` and `updateHTML` function for managing inner HTML reactively.
`packages/fluent-editor/src/attributors/font-size.ts`	Introduced `SizeStyle` attributor for manipulating font size in the Quill editor.
`packages/fluent-editor/src/attributors/font-style.ts`	Introduced `FontStyle` attributor for managing font family in the Quill editor.
`packages/fluent-editor/src/attributors/line-height.ts`	Introduced `LineHeightStyle` attributor for managing line height in the Quill editor.
`packages/fluent-editor/src/attributors/text-indent.ts`	Introduced `TextIndentStyle` attributor for managing text indentation in the Quill editor.
`packages/fluent-editor/src/attributors/index.ts`	Created central export file for text styling attributors.
`packages/fluent-editor/src/config.ts`	Removed `FONT_FAMILY_CONFIG` and `FONT_SIZE_CONFIG` constants.
`packages/fluent-editor/src/fluent-editor.ts`	Updated imports and registration of modules; removed old font configurations.
`packages/fluent-editor/src/table/table-config.ts`	Expanded `CELL_ATTRIBUTES` to include a new `'list'` attribute.
`packages/fluent-editor/src/lineheight.ts`	Removed `lineheight.ts` file, eliminating previous line height management functionality.

Possibly related PRs

#62: Involves updating the syntax highlighting configuration in get-html.vue, which relates to managing the inner HTML and integrating syntax highlighting features.

Suggested labels

refactoring

Poem

🐰 In the garden of code, we hop and play,
With new styles and functions, brightening the day.
Font sizes and indents, all neatly aligned,
A tapestry of text, beautifully designed.
So let’s celebrate changes, both big and small,
For in this editor, we’ll style it all! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

kagol commented 1 month ago

@zzxming text-indent 未生效，其他的都OK了