Closed zzxming closed 1 month ago
The pull request introduces modifications to Vue component scripts and TypeScript files related to screenshot functionality. Changes include updates to import statements, the declaration of references, and the restructuring of functions to enhance clarity and maintainability. Key adjustments involve the screenshot-upload-to-server.vue
and screenshot.vue
files, where lifecycle hooks and global variables are utilized. Additionally, the index.ts
file in the screenshot directory sees type changes and function updates, while the imgToBase64
function in image.ts
transitions to a standard function declaration.
File(s) | Change Summary |
---|---|
packages/docs/fluent-editor/demos/screenshot-upload-to-server.vue , packages/docs/fluent-editor/demos/screenshot.vue |
Adjusted import statements for onMounted and ref , declared editorRef as a reference, utilized onMounted to dynamically import FluentEditor , and added window.Html2Canvas for global access. |
packages/fluent-editor/src/screenshot/index.ts |
Reordered import statements, changed ScreenShotOptionsInQuill from type alias to interface, updated resolveOptions from constant to function declaration, and modified renderImage to include an optional parameter. |
packages/fluent-editor/src/utils/image.ts |
Changed imgToBase64 from an arrow function to a standard function declaration, updated error handling to use template literals, while preserving overall logic and promise structure. |
FluentEditor
and implement screenshot functionality, which is directly related to the modifications made in the main PR regarding screenshot features.imgToBase64
function, which is relevant to the changes made in the main PR that also involve screenshot handling.🐇 In the garden of code we play,
With screenshots taken in a new way.
Imports adjusted, functions refined,
A smoother path for all to find.
With every change, our project grows,
Hopping forward, as progress flows! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
.md
/.yaml
/.json
and more filesIssue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes
Chores
Style