opentiny / tiny-vue

TinyVue is an enterprise-class UI component library of OpenTiny community, support both Vue.js 2 and Vue.js 3, as well as PC and mobile.
https://opentiny.design/tiny-vue
MIT License
1.67k stars 266 forks source link

test(e2e): [base-select,slider,time-select,tag,icon]fix e2e test error #2408

Closed zzcr closed 3 weeks ago

zzcr commented 3 weeks ago

PR

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The pull request includes modifications to various test files in a Playwright testing suite, primarily focusing on adjusting test cases related to visual styling, component interactions, and expected dimensions. Key changes involve commenting out certain actions, updating expected CSS properties, and removing references to components and functions. Notably, tests now emphasize visibility checks over interactions, reflecting adjustments in the underlying component structure and styling.

Changes

File Path Change Summary
examples/sites/demos/pc/app/base-select/copy-multi.spec.ts Modifications to test cases, focusing on visibility of copyIcon instead of actions involving copyValueInput.
examples/sites/demos/pc/app/base-select/input-box-type.spec.ts Updated class assertions from tiny-base-select__underline to tiny-input-underline and changed border color assertions.
examples/sites/demos/pc/app/base-select/popup-style-position.spec.ts Removed assertion for x-placement attribute on dropdown element.
examples/sites/demos/pc/app/base-select/size.spec.ts Adjusted expected CSS heights for input elements across different size specifications.
examples/sites/demos/pc/app/icon/show-title.spec.ts Deleted test case for title visibility, including error handling during page load.
examples/sites/demos/pc/app/select/size.spec.ts Updated expected height values for various input sizes in tests.
examples/sites/demos/pc/app/slider/shortcut-operation.spec.ts Changed interaction method for slider from hover to click, with added delays after key presses.
examples/sites/demos/pc/app/tabs/tab-style-bordercard.spec.ts Updated expected CSS background color for tab header.
examples/sites/demos/pc/app/tag/size.spec.ts Changed expected CSS height for mini tag from '17px' to '18px'.
examples/sites/demos/pc/app/time-picker/event-composition-api.vue Removed button and associated focus handling for time picker component.
examples/sites/demos/pc/app/time-picker/event.spec.ts Removed lines interacting with focus button and time selection element.
examples/sites/demos/pc/app/time-picker/event.vue Removed focus-triggering button and updated component bindings, simplifying the template.

Possibly related PRs

Suggested labels

e2e-test

Poem

🐇 In the land of code, where rabbits play,
Changes hop along, brightening the day.
With tests that now check for icons in sight,
And colors that shift, oh what a delight!
So let’s celebrate with a joyful cheer,
For every small change brings us all near! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.