coderabbitai[bot]
commented
2 weeks ago Walkthrough
The changes in this pull request involve updates to two Vue component files (image-composition-api.vue and image.vue) and a LESS file (index.less). Both Vue components have had their image sources changed from email.png to button-image.png, and the width attribute in the img tags has been removed. Additionally, both components now include the scoped attribute in their style sections. The LESS file has modifications to the button's display properties, changing it from inline-block to inline-flex and adding vertical centering for better alignment of button contents.
Changes
| File | Change Summary |
|---|---|
| examples/sites/demos/pc/app/button/image-composition-api.vue, examples/sites/demos/pc/app/button/image.vue | Updated image source from email.png to button-image.png, removed width attribute from img tags, and added scoped attribute to <style>. |
| packages/theme/src/button/index.less | Changed button class display from inline-block to inline-flex and added align-items: center for vertical alignment. |
Possibly related PRs
- #2088: Updates the image source in
image-composition-api.vueandimage.vue, directly related to image handling in button components. - #2104: Similar image source updates in button components, reinforcing the connection to the main PR.
- #2120: Modifies the image source in the button component, aligning with the main PR's focus on image handling.
- #2148: Involves button styling and image handling, relevant to the main PR's modifications.
- #2172: Focuses on button styling, pertinent to the changes in the main PR regarding image handling.
- #2423: Addresses centering issues of icon buttons, connecting to the visual presentation changes in the main PR.
- #2427: Optimizes demo style for button features, relevant to the main PR's changes in button presentation and styling.
Suggested reviewers
- zzcr
Poem
🐇 In the meadow where buttons gleam,
A new image shines, like a sweet dream.
With styles scoped and centered tight,
Our buttons now dance in pure delight!
Hopping along, we celebrate the change,
In our vibrant world, nothing feels strange! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
PR
效果如下：
之前的效果：
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes
widthattribute fromimgtags to improve image rendering.Style
scopedstyles to prevent style leakage between components.