Improve compatibility in the 4.x GLControl

seanofw commented 3 years ago

This includes (maybe?) a fix for the Control.Site null-reference issue some people have run into. I can't reproduce it myself, so this simply adds an extra null check in hopes that that'll make the issue go away.
This adds a Load event (and an overridable OnLoad method) for better backward-compatibility with the 3.x GLControl. That control inherited UserControl, which wasn't necessary and which added in lots of irrelevant events; but it seems some people were dependent on its provided Load event, so I've added an equivalent Load event for backward-compatibility, based on the way the Load event is fired in UserControl itself.

seanofw commented 3 years ago

NOTE: This pull request is waiting, pending testing from various people who have run into the Control.Site issue. Since I can't reproduce the bug, I can't be certain that this PR will fix it; this is just my best guess at a reasonable solution.

varon commented 3 years ago

@seanofw - Thanks for the fix.

If you can ping me on discord when this is ready for a review + merge, would appreciate it!

varon commented 3 years ago

Thanks for the ping @seanofw - Looks great. Merged.

opentk / GLControl

Improve compatibility in the 4.x GLControl #2