search

opentk / LearnOpenTK

A port of learnopengl.com's tutorials to OpenTK and C#.
Creative Commons Attribution 4.0 International
463 stars 115 forks source link

Add punctation + Rephrase some comments #56

Closed Paphos closed 3 years ago

Paphos commented 3 years ago

Hi there!

I added some punctation where it was needed, fixed some typo, and rephrase some comments that were not very clear. It is likely that I may have added new mistakes, as English is not my first language! 😅 So let me know if you see one! 😊

I also fixed the color calculation in the "4-Shader-Uniforms" tutorial: the green color was oscillating between -0.5f and 0.5f, instead of 0f and 1f.

And thank you everyone for these awesome tutorials! As someone coming from the MonoGame/XNA world, it really helped me to get truly into OpenGL!! 🥳

deccer commented 3 years ago

Hi Paphos, thank you for your contribution.

I understand punctuation in full sentences, explanations and

regions, but not in simple comments like "// Add a handle for the EBO." If you remove punctation from those then this is alright.

Paphos commented 3 years ago

Oh right, I see what you mean. Fixed!

Paphos commented 3 years ago

I also fixed the issue #41 at the same time 😊 The PR is ready to be merged on my side! I will maybe do the same for Chapter-2 in another PR if I find some time. 😅