search

opentk / LearnOpenTK

A port of learnopengl.com's tutorials to OpenTK and C#.
Creative Commons Attribution 4.0 International
463 stars 115 forks source link

wrong accessibility level for Shader.Use() #60

Closed approachcircle closed 3 years ago

approachcircle commented 3 years ago

in 1.2 Hello Triangle's documentation, section Compiling the Shaders, a Use() method is defined in the Shader class, but there was no explicit accessibility level defined for the method so it defaulted to private meaning that the program would compile with error CS0122. the method should've been defined as: public void Use() { GL.UseProgram(Handle); } so that it is accessible to members outside of its class. it has the correct accessibility level in this repository here though.

NogginBops commented 3 years ago

If you want to fix this issue it would be great if you could open a PR in this repo on the docfx branch. :)

approachcircle commented 3 years ago

that's a good idea, i was trying to find a link to the documentation's github on the page itself, but i'll go open a pr on that repository now