search

opentk / opentk

The Open Toolkit library is a fast, low-level C# wrapper for OpenGL, OpenAL & OpenCL. It also includes windowing, mouse, keyboard and joystick input and a robust and fast math library, giving you everything you need to write your own renderer or game engine. OpenTK can be used standalone or inside a GUI on Windows, Linux, Mac.
https://opentk.net
Other
3.2k stars 629 forks source link

Wrong return value for glWaitSync #168

Closed TillAlex closed 8 years ago

TillAlex commented 10 years ago

According to OpengL specs glWaitSync has void as return value. In ES namespaces the return values are correct, but in OpenGL namespaces the DLLImport glWaitSync as well as the GL.WaitSync(...) have wrong return types.

As I understand return type WaitSyncStatus is only returned by glClientWaitSync(...)

thefiddler commented 10 years ago

Thanks, fixed in https://github.com/opentk/opentk/pull/169

Since this is an ABI-breaking change, it will be included in the 1.2 release.

TillAlex commented 10 years ago

Thanks for the fix.

Just to be sure that I fixed this correctly in my build: Is it enough to change the signatures in the following files?

Or are there any other files the generator is using which have to fixed?

thefiddler commented 10 years ago

It's just those two files.

In general, you modify overrides.xml then re-run Generator.Bind to update the bindings.