search

opentofu / setup-opentofu

Mozilla Public License 2.0
89 stars 10 forks source link

Enhance release.js tests to calling github API #13

Closed kislerdm closed 1 year ago

kislerdm commented 1 year ago

Problem

The test release.js mocks HTTP calls to github API wrongly. It led to testing side effects and unnecessarily quota consumption, see example.

Proposed Solution

Fix the "unhappy path" tests relying on the mock function fetchReleases

As a nit, nock can be removed from dependencies because it's not used.