Description

For video recording, added support for multiArchiveTag and layout properties. In the current implementation, the array_intersect_key function removes all received options except the default ones.

Motivation and Context

Bug fix

How Has This Been Tested?

Test suite passes

Example Output or Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 1 year ago

Codecov Report

Merging #325 (a2c30f1) into main (dd71a9a) will decrease coverage by 0.4%. The diff coverage is 42.8%.

Impacted Files	Coverage Δ
src/OpenTok/Util/Validators.php	`70.1% <25.0%> (-1.8%)`	:arrow_down:
src/OpenTok/OpenTok.php	`90.3% <66.6%> (-0.7%)`	:arrow_down:

SecondeJK commented 1 year ago

The test suite passes, but codecov is blocking this from being merged. I can look at a way to increase coverage if needed, but is it possible to look at the report and identify new or existing blocks of code that will bring us back up to 78.1%?

I realise it's arbitrary, but also we have had to get quality checks very slowly into this library

opentok / OpenTok-PHP-SDK

Added optional properties when starting archiving #325