opentok / OpenTok-PHP-SDK

OpenTok PHP Server SDK
https://tokbox.com/developer/sdks/php/
MIT License
140 stars 145 forks source link

Add end-to-end encryption when creating session. #327

Closed SecondeJK closed 1 year ago

SecondeJK commented 1 year ago

This PR adds the end to end encryption flag when starting an OpenTok Session.

Description

See the docs for more context: https://tokbox.com/developer/guides/end-to-end-encryption/

Motivation and Context

New features being rolled into our SDKs

How Has This Been Tested?

Added new test and modified existing one to make sure defaults are read properly.

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #327 (1427f7f) into main (c85f458) will increase coverage by 2.0%. The diff coverage is 100.0%.

:exclamation: Current head 1427f7f differs from pull request most recent head 811cc98. Consider uploading reports for the commit 811cc98 to get more accurate results

Impacted Files Coverage Δ
src/OpenTok/OpenTok.php 91.4% <100.0%> (+0.3%) :arrow_up:
src/OpenTok/Session.php 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

SecondeJK commented 1 year ago

@jeffswartz I've not bumped the hardcoded version number as #328 will rewrite how this is handled (actually addresses a TODO from 2014 on dynamic user agent string handling)