set default to 15 - Githubissues

opentok / cordova-plugin-opentok

Cordova Plugin for OpenTok - add webrtc video to your iOS or Android App

MIT License

30 stars 80 forks source link

set default to 15 #117

Closed msach22 closed 6 years ago

msach22 commented 6 years ago

Contributing checklist

[x] Code must follow existing styling conventions
[x] Added a descriptive commit message

Solves issue(s)

msach22 commented 6 years ago

@mark-veenstra let me know what you think!

mark-veenstra commented 6 years ago

@msach22 Just got back from vacation, maybe scheduling a call will help indeed. Just changing this setting doesn't help! The problem is it does not matter wat you set on that line. The framerate wil always be wrong. So it is something within the SDK.

Have you tested this codebase with this setting as you propose? You can than also see that the setting won't do anything on Android when you open the session inspector.

mark-veenstra commented 6 years ago

@msach22 As I just checked through all emails the session ids shared with you shows a frameRate of 15 in your internal logs. But the bitrate is till doubled. So why is the bitrate still doubled?

msach22 commented 6 years ago

Cherry picked and added to 3.4.0