opentok / cordova-plugin-opentok

Cordova Plugin for OpenTok - add webrtc video to your iOS or Android App

MIT License

30 stars 80 forks source link

Automatically update views when a stream is created #136

Closed msach22 closed 5 years ago

msach22 commented 5 years ago

Feature Request

Description

(Include problem, use cases, benefits, and/or goals) Currently, Ionic applications have to manually call OT.updateViews when they subscribe to a stream. Proposal We can detect if it's an Ionic application and call OT.updateViews automatically so the application layer does not have to do it.

Links / references

mark-veenstra commented 5 years ago

The PR https://github.com/opentok/cordova-plugin-opentok/pull/59 is already implementing such a feature

msach22 commented 5 years ago

Yes, but we can't merge #59 in because it drops support for some Android platforms that OpenTok still supports.

Shtibel commented 5 years ago

when will this be updated?

msach22 commented 5 years ago

This has been released with v3.4.3

Shtibel commented 5 years ago

Hi @msach22 , So now we don't need to do OT.updateViews anymore? It updates every time there is a change in DOM ?

msach22 commented 5 years ago

@Shtibel OT.updateViews is only called by the plugin when a stream is created, not when there are changes any in the DOM.

Currently, we are unable to add it when there are all DOM changes because we still plan on supporting Android 16.

Shtibel commented 5 years ago

Ok thank you @msach22.

msach22 commented 5 years ago

I'l update you if we can do things without dropping support!