fix(q): :bug: could not install plugin on cordova 9+ Closes #180

opentok / cordova-plugin-opentok

Cordova Plugin for OpenTok - add webrtc video to your iOS or Android App

MIT License

30 stars 80 forks source link

fix(q): :bug: could not install plugin on cordova 9+ Closes #180 #199

Closed cadesalaberry closed 3 years ago

cadesalaberry commented 3 years ago

the error message is an attempt to communicate that we do not really want to support using "requireCordovaModule" to load non-Cordova module "q" any longer.

https://github.com/apache/cordova/issues/52#issuecomment-475696680 https://stackoverflow.com/questions/55304065/cordova-error-using-requirecordovamodule-to-load-non-cordova-module-q-is-no

Contributing checklist

[x] Code must follow existing styling conventions
[x] Added a descriptive commit message

Solves issue(s)

cadesalaberry commented 3 years ago

@msach22 @enricop89 do you mind having a look ? I was not able to use the plugin without this modification.

michaeljolley commented 3 years ago

Thanks for the fix @cadesalaberry!