search

opentok / cordova-plugin-opentok

Cordova Plugin for OpenTok - add webrtc video to your iOS or Android App
MIT License
30 stars 80 forks source link

Screen Sharing #95

Open msach22 opened 6 years ago

msach22 commented 6 years ago

Feature Request

WIP

Description Add the ability to share the screen of the application

Proposal

Links / references

msach22 commented 6 years ago

@mark-veenstra Hey Mark, I've started to work on screen sharing and I'm wondering if you think having multiple publishers will be a good idea. Like publishing from the camera and the screen at the same time.

mark-veenstra commented 6 years ago

@msach22 I think it would be nice indeed to share camera and screen at the same time. So multiple publishers seems to be necessary

msach22 commented 6 years ago

@mark-veenstra Just to clarify, the screen share would show the publisher as a part of the screen so it would take up quite a bit of real estate considering mobile screens are small.

The initial screen share feature would only support one publisher, but we can increase that support to multiple publishers in the second iteration if there is high demand for it.

mark-veenstra commented 6 years ago

@msach22 I really think it is not a good idea to build in limitations. I would like to keep designs to designers and open up possibilities to create a lovely interface. For example we have created an interface where the end-user can place camera/screen views on the screen where he/she likes. Also he/she can choose which ones will be main big ones and which will be smaller/less important ones.

And if there are too many participants we create a small scroll view where you can scroll through all the other participants.

We have created this interface so we are not limited to the count of participants and it works really nice. I can ask @wolfenrain to make a video of this setup to give you an idea. It is based on the https://github.com/aullman/opentok-layout-js idea, but with a different setup for mobilea allowing to have a scroll of participants.

Therefore we think it is better to have a camera and a screen publisher. The developers making use of OpenTok can than decided for themselves if they place both views somewhere in the design or maybe even stop the camera publisher and only add the screen. But this decision should be made by the developers/designers and not by default by this plugin.

msach22 commented 6 years ago

@mark-veenstra Sounds good Mark, I will work on multiple publisher support this week and add that as well. I'd love to see the video set up so please share that when you can!

wolfenrain commented 6 years ago

@msach22 @mark-veenstra as promised, https://drive.google.com/file/d/1xPPGTEcPs91OaQQkhflipNbamRHoUK_0/view?usp=sharing

msach22 commented 6 years ago

@wolfenrain This looks great! Are you open to having this as an external package? Similar to the opentok-layout-js. Let me know what you think!

msach22 commented 6 years ago

@mark-veenstra @wolfenrain I investigated supporting multiple publishers and it would require some breaking changes so I'm going to hold off on adding support for multiple publishers until we have more demand. We may still release screen sharing, but I will keep you both updated!

rhclayto commented 5 years ago

@msach22 @mark-veenstra as promised, https://drive.google.com/file/d/1xPPGTEcPs91OaQQkhflipNbamRHoUK_0/view?usp=sharing

This is cool. Can you share what you did to create this? Code maybe? Thanks for sharing the video.

Shtibel commented 5 years ago

Hi @wolfenrain @mark-veenstra @msach22 ,

The video demo is very nice !!! How did you manage to add the bottom strip with the buttons on top of the videos? Is it HTML elements on top of it? how did you manage to show it ? Dose it also work on IOS ? In my code all the HTML is under the native videos.